admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reduce PC level Smoke test flakiness

Browse Source 
Increase test duration to make at least one frame to come through on slow
test bots and remove check in echo emulation for same purposes. Logging
for echo queue should be enough.

Bug: None
Change-Id: I0d2d1c2a87e1a2b4cd035828443f428b0983edad
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176300
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31377}
This commit is contained in:
Artem Titov 2020-05-28 15:53:41 +02:00 committed by Commit Bot
parent ed5d594730
commit e5f2d58147
2 changed files with 7 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/pc/e2e/echo/echo_emulation.cc
View File

@ -57,17 +57,7 @@ void EchoEmulatingCapturer::OnAudioRendered(
}
queue_input_.assign(data.begin(), data.end());
if (!renderer_queue_.Insert(&queue_input_)) {
// Test audio device works too slow with sanitizers and on some platforms
// and can't properly process audio, so when capturer will be stopped
// renderer will quickly overfill the queue.
// TODO(crbug.com/webrtc/10850) remove it when test ADM will be fast enough.
#if defined(THREAD_SANITIZER) || defined(MEMORY_SANITIZER) || \
defined(ADDRESS_SANITIZER) || defined(WEBRTC_ANDROID) || \
(defined(_MSC_VER) && !defined(__clang__) && !defined(NDEBUG))
RTC_LOG(WARNING) << "Echo queue is full";
#else
RTC_CHECK(false) << "Echo queue is full";
#endif
}
}

14
test/pc/e2e/peer_connection_e2e_smoke_test.cc
View File

@ -83,7 +83,7 @@ class PeerConnectionE2EQualityTestSmokeTest : public ::testing::Test {
auto fixture = CreatePeerConnectionE2EQualityTestFixture(
test_case_name, /*audio_quality_analyzer=*/nullptr,
std::move(video_quality_analyzer));
fixture->ExecuteAt(TimeDelta::Seconds(2),
fixture->ExecuteAt(TimeDelta::Seconds(3),
[alice_network_behavior_ptr](TimeDelta) {
BuiltInNetworkBehaviorConfig config;
config.loss_percent = 5;
@ -136,7 +136,7 @@ class PeerConnectionE2EQualityTestSmokeTest : public ::testing::Test {
#define MAYBE_Smoke Smoke
#endif
TEST_F(PeerConnectionE2EQualityTestSmokeTest, MAYBE_Smoke) {
RunParams run_params(TimeDelta::Seconds(2));
RunParams run_params(TimeDelta::Seconds(3));
run_params.video_codecs = {
VideoCodecConfig(cricket::kVp9CodecName, {{"profile-id", "0"}})};
run_params.use_flex_fec = true;
@ -173,7 +173,7 @@ TEST_F(PeerConnectionE2EQualityTestSmokeTest, MAYBE_Smoke) {
screenshare.stream_label = "charlie-screenshare";
screenshare.content_hint = VideoTrackInterface::ContentHint::kText;
ScreenShareConfig screen_share_config =
ScreenShareConfig(TimeDelta::Seconds(2));
ScreenShareConfig(TimeDelta::Seconds(3));
screen_share_config.scrolling_params = ScrollingParams(
TimeDelta::Millis(1800), kDefaultSlidesWidth, kDefaultSlidesHeight);
auto screen_share_frame_generator =
@ -197,7 +197,7 @@ TEST_F(PeerConnectionE2EQualityTestSmokeTest, MAYBE_Smoke) {
#define MAYBE_Echo Echo
#endif
TEST_F(PeerConnectionE2EQualityTestSmokeTest, MAYBE_Echo) {
RunParams run_params(TimeDelta::Seconds(2));
RunParams run_params(TimeDelta::Seconds(3));
run_params.echo_emulation_config = EchoEmulationConfig();
RunTest(
"smoke", run_params,
@ -227,7 +227,7 @@ TEST_F(PeerConnectionE2EQualityTestSmokeTest, MAYBE_Echo) {
#define MAYBE_Simulcast Simulcast
#endif
TEST_F(PeerConnectionE2EQualityTestSmokeTest, MAYBE_Simulcast) {
RunParams run_params(TimeDelta::Seconds(2));
RunParams run_params(TimeDelta::Seconds(3));
run_params.video_codecs = {VideoCodecConfig(cricket::kVp8CodecName)};
RunTest(
"simulcast", run_params,
@ -265,7 +265,7 @@ TEST_F(PeerConnectionE2EQualityTestSmokeTest, MAYBE_Simulcast) {
#define MAYBE_Svc Svc
#endif
TEST_F(PeerConnectionE2EQualityTestSmokeTest, MAYBE_Svc) {
RunParams run_params(TimeDelta::Seconds(2));
RunParams run_params(TimeDelta::Seconds(3));
run_params.video_codecs = {VideoCodecConfig(cricket::kVp9CodecName)};
RunTest(
"simulcast", run_params,
@ -305,7 +305,7 @@ TEST_F(PeerConnectionE2EQualityTestSmokeTest, MAYBE_Svc) {
#define MAYBE_HighBitrate HighBitrate
#endif
TEST_F(PeerConnectionE2EQualityTestSmokeTest, MAYBE_HighBitrate) {
RunParams run_params(TimeDelta::Seconds(2));
RunParams run_params(TimeDelta::Seconds(3));
run_params.video_codecs = {
VideoCodecConfig(cricket::kVp9CodecName, {{"profile-id", "0"}})};