From e5ae6f82374cb064d39cffffdb650840f734880f Mon Sep 17 00:00:00 2001 From: peah Date: Sun, 13 Dec 2015 23:02:33 -0800 Subject: [PATCH] Correcting the check for the return code produced by AudioProcessing::ProcessReverseStream(). Before the change, only -1 was considered to be an error. Allthough the error code scheme for AudioProcessing definitely could be discussed, the current scheme have many error codes that differ from -1 and thus were not caught by the old code. BUG=webrtc:5237 Review URL: https://codereview.webrtc.org/1515073004 Cr-Commit-Position: refs/heads/master@{#11003} --- webrtc/voice_engine/output_mixer.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webrtc/voice_engine/output_mixer.cc b/webrtc/voice_engine/output_mixer.cc index 1b4d2e23b3..d46ee6296d 100644 --- a/webrtc/voice_engine/output_mixer.cc +++ b/webrtc/voice_engine/output_mixer.cc @@ -550,7 +550,7 @@ OutputMixer::DoOperationsOnCombinedSignal(bool feed_data_to_apm) // ---------------------------------------------------------------------------- void OutputMixer::APMProcessReverseStream() { - if (_audioProcessingModulePtr->ProcessReverseStream(&_audioFrame) == -1) { + if (_audioProcessingModulePtr->ProcessReverseStream(&_audioFrame) != 0) { WEBRTC_TRACE(kTraceError, kTraceVoice, VoEId(_instanceId, -1), "AudioProcessingModule::ProcessReverseStream() => error"); }