From e5abac443a5cbaf5acdcdc7c0876f8ba2aa48ad1 Mon Sep 17 00:00:00 2001 From: kjellander Date: Tue, 5 Sep 2017 10:14:51 -0700 Subject: [PATCH] Revert of Add //build/android/pylib/results/ to Android isolate packaging (patchset #1 id:1 of https://codereview.webrtc.org/3006103002/ ) Reason for revert: Breaks memcheck bot: https://build.chromium.org/p/client.webrtc/builders/Linux%20Memcheck/builds/11554 Edward: do you understand why? I'll run a full CQ set before relanding for sure. Original issue's description: > Add //build/android/pylib/results/ to Android isolate packaging > > This is needed before relanding > https://chromium-review.googlesource.com/c/chromium/tools/build/+/619228 > > TESTED= > I built tools_unittests and verified build/android/pylib/results/presentation/test_results_presentation.py > is listed in the .isolated file: > OUT=out/android-Release > TEST=tools_unittests > tools_webrtc/mb/mb.py isolate //$OUT $TEST > tools/swarming_client/isolate.py archive -I https://isolateserver.appspot.com -i $OUT/$TEST.isolate -s $OUT/$TEST.isolated > > BUG=chromium:717417 > NOTRY=True > > Review-Url: https://codereview.webrtc.org/3006103002 > Cr-Commit-Position: refs/heads/master@{#19695} > Committed: https://chromium.googlesource.com/external/webrtc/+/f8ff0282c6b605f16fa5464b9496be1f6bac35ed TBR=ehmaldonado@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:717417 Review-Url: https://codereview.webrtc.org/3008083004 Cr-Commit-Position: refs/heads/master@{#19696} --- webrtc/webrtc.gni | 9 --------- 1 file changed, 9 deletions(-) diff --git a/webrtc/webrtc.gni b/webrtc/webrtc.gni index 7e74161c57..af4d6f97db 100644 --- a/webrtc/webrtc.gni +++ b/webrtc/webrtc.gni @@ -265,7 +265,6 @@ template("rtc_test") { "*", [ "configs", - "data", "public_configs", "suppressed_configs", ]) @@ -279,14 +278,6 @@ template("rtc_test") { if (!build_with_chromium && is_android) { android_manifest = webrtc_root + "test/android/AndroidManifest.xml" deps += [ webrtc_root + "test:native_test_java" ] - - # Needed for build/android/pylib/results/presentation/test_results_presentation.py - data = [ - "//build/android/pylib/results/", - ] - if (defined(invoker.data)) { - data += invoker.data - } } } }