From e5297d2aaa8920df8d2b8c6cd784222ff6fc9e2d Mon Sep 17 00:00:00 2001 From: "mflodman@webrtc.org" Date: Tue, 17 Jan 2012 12:44:41 +0000 Subject: [PATCH] Big parameter passed as argument. BUG=C-10503, C-10504, C-10505 Review URL: https://webrtc-codereview.appspot.com/343011 git-svn-id: http://webrtc.googlecode.com/svn/trunk@1441 4adac7df-926f-26a2-2b94-8c16560cd09d --- src/video_engine/include/vie_capture.h | 2 +- src/video_engine/vie_capture_impl.cc | 2 +- src/video_engine/vie_capture_impl.h | 2 +- src/video_engine/vie_capturer.cc | 2 +- src/video_engine/vie_capturer.h | 2 +- src/video_engine/vie_file_recorder.cc | 2 +- src/video_engine/vie_file_recorder.h | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/video_engine/include/vie_capture.h b/src/video_engine/include/vie_capture.h index dad97097e8..45d62e5174 100644 --- a/src/video_engine/include/vie_capture.h +++ b/src/video_engine/include/vie_capture.h @@ -191,7 +191,7 @@ class WEBRTC_DLLEXPORT ViECapture { // Makes a capture device start capturing video frames. virtual int StartCapture( const int capture_id, - const CaptureCapability capture_capability = CaptureCapability()) = 0; + const CaptureCapability& capture_capability = CaptureCapability()) = 0; // Stops a started capture device from capturing video frames. virtual int StopCapture(const int capture_id) = 0; diff --git a/src/video_engine/vie_capture_impl.cc b/src/video_engine/vie_capture_impl.cc index 213a4166f8..2da9c81230 100644 --- a/src/video_engine/vie_capture_impl.cc +++ b/src/video_engine/vie_capture_impl.cc @@ -279,7 +279,7 @@ int ViECaptureImpl::DisconnectCaptureDevice(const int video_channel) { } int ViECaptureImpl::StartCapture(const int capture_id, - const CaptureCapability capture_capability) { + const CaptureCapability& capture_capability) { WEBRTC_TRACE(kTraceApiCall, kTraceVideo, ViEId(instance_id_), "%s(capture_id: %d)", __FUNCTION__, capture_id); diff --git a/src/video_engine/vie_capture_impl.h b/src/video_engine/vie_capture_impl.h index e6dda9f765..d8ce774d4c 100644 --- a/src/video_engine/vie_capture_impl.h +++ b/src/video_engine/vie_capture_impl.h @@ -45,7 +45,7 @@ class ViECaptureImpl virtual int DisconnectCaptureDevice(const int video_channel); virtual int StartCapture( const int capture_id, - const CaptureCapability capture_capability = CaptureCapability()); + const CaptureCapability& capture_capability = CaptureCapability()); virtual int StopCapture(const int capture_id); virtual int SetRotateCapturedFrames(const int capture_id, const RotateCapturedFrame rotation); diff --git a/src/video_engine/vie_capturer.cc b/src/video_engine/vie_capturer.cc index 6082fc4b2b..a8ef35e8c3 100644 --- a/src/video_engine/vie_capturer.cc +++ b/src/video_engine/vie_capturer.cc @@ -211,7 +211,7 @@ int ViECapturer::FrameCallbackChanged() { return 0; } -WebRtc_Word32 ViECapturer::Start(const CaptureCapability capture_capability) { +WebRtc_Word32 ViECapturer::Start(const CaptureCapability& capture_capability) { WEBRTC_TRACE(kTraceInfo, kTraceVideo, ViEId(engine_id_, capture_id_), "%s", __FUNCTION__); int width; diff --git a/src/video_engine/vie_capturer.h b/src/video_engine/vie_capturer.h index 4f125d371d..da68278d62 100644 --- a/src/video_engine/vie_capturer.h +++ b/src/video_engine/vie_capturer.h @@ -78,7 +78,7 @@ class ViECapturer // Start/Stop. WebRtc_Word32 Start( - const CaptureCapability capture_capability = CaptureCapability()); + const CaptureCapability& capture_capability = CaptureCapability()); WebRtc_Word32 Stop(); bool Started(); diff --git a/src/video_engine/vie_file_recorder.cc b/src/video_engine/vie_file_recorder.cc index b909ff5645..7dc6ff743e 100644 --- a/src/video_engine/vie_file_recorder.cc +++ b/src/video_engine/vie_file_recorder.cc @@ -40,7 +40,7 @@ int ViEFileRecorder::StartRecording(const char* file_nameUTF8, const VideoCodec& codec_inst, AudioSource audio_source, int audio_channel, - const CodecInst audio_codec_inst, + const CodecInst& audio_codec_inst, VoiceEngine* voe_ptr, const FileFormats file_format) { CriticalSectionScoped lock(*recorder_cs_); diff --git a/src/video_engine/vie_file_recorder.h b/src/video_engine/vie_file_recorder.h index 99f3d23457..1d34ad35b5 100644 --- a/src/video_engine/vie_file_recorder.h +++ b/src/video_engine/vie_file_recorder.h @@ -28,7 +28,7 @@ class ViEFileRecorder : protected OutStream { int StartRecording(const char* file_nameUTF8, const VideoCodec& codec_inst, AudioSource audio_source, int audio_channel, - const CodecInst audio_codec_inst, + const CodecInst& audio_codec_inst, VoiceEngine* voe_ptr, const FileFormats file_format = kFileFormatAviFile); int StopRecording();