admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[NotJavadoc] Avoid using /** for comments which aren't actually Javadoc.

Browse Source 
Error surfaces when rolling https://chromium-review.googlesource.com/c/chromium/src/+/5901711 in WebRTC.

https://ci.chromium.org/ui/p/webrtc/builders/try/android_arm64_rel/78284/overview

Change-Id: Iad096c7c2cf9b1fabe9ce0abdb8f3da3fc8058d9
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/364840
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Auto-Submit: Jeremy Leconte <jleconte@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43182}
This commit is contained in:
Jeremy Leconte 2024-10-07 13:57:37 +02:00 committed by WebRTC LUCI CQ
parent 01f91c81f7
commit e466ae8184
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sdk/android/src/java/org/webrtc/EglBase10Impl.java
View File

@ -193,11 +193,9 @@ class EglBase10Impl implements EglBase10 {
@Override
public void createSurface(Surface surface) {
/**
* We have to wrap Surface in a SurfaceHolder because for some reason eglCreateWindowSurface
* couldn't actually take a Surface object until API 17. Older versions fortunately just call
* SurfaceHolder.getSurface(), so we'll do that. No other methods are relevant.
*/
// We have to wrap Surface in a SurfaceHolder because for some reason eglCreateWindowSurface
// couldn't actually take a Surface object until API 17. Older versions fortunately just call
// SurfaceHolder.getSurface(), so we'll do that. No other methods are relevant.
class FakeSurfaceHolder implements SurfaceHolder {
private final Surface surface;