admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Do not log on stderr on Android tests."

Browse Source 
This reverts commit c48a2653466f926ecc1d259a16ede304333fc14b.

Reason for revert: logcat issue should be fixed with https://crrev.com/c/4055461.

Original change's description:
> Do not log on stderr on Android tests.
>
> On Pixel 2, this causes an increase in flakiness. This needs to be
> reenabled once the root cause is fixed.
>
> Bug: chromium:1384172, b/259113795
> Change-Id: Ie94d3e2daad3a2de5af673c763362ea1b42fde7d
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283522
> Reviewed-by: Jeremy Leconte <jleconte@google.com>
> Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#38623}

Bug: chromium:1384172, b/259113795
Change-Id: Iadd7c484f4e73deea952df7980acc0164c96a592
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285021
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#38731}
This commit is contained in:
Jeremy Leconte 2022-11-25 05:59:02 +00:00 committed by WebRTC LUCI CQ
parent b5e5b8a6c4
commit e40bb38faa
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/test_main_lib.cc
View File

@ -90,13 +90,7 @@ ABSL_FLAG(bool,
false,
"Tells to initialize new API for exporting performance metrics");
// TODO(crbug.com/1384172): Re-enable logs by default once the issue with
// logcat is solved.
#if defined(WEBRTC_ANDROID)
ABSL_FLAG(bool, logs, false, "print logs to stderr");
#else
ABSL_FLAG(bool, logs, true, "print logs to stderr");
#endif
ABSL_FLAG(bool, verbose, false, "verbose logs to stderr");
ABSL_FLAG(std::string,