From e3a4da9f44242c8728892d8a92986679ddd0ad31 Mon Sep 17 00:00:00 2001 From: Henrik Lundin Date: Mon, 6 Nov 2017 11:42:21 +0100 Subject: [PATCH] AGC: Change default clipping level min to 70 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The old value was 170, but experiments have shown that 70 is better. This will let the AGC reduce the gain further when input clipping is detected. The effect should be less clipping, but sometimes slightly lower signals. In Chrome, the value 70 has already been used since June (see https://codereview.chromium.org/2928133002). Bug: webrtc:6622, chromium:672476 Change-Id: Ie5a60bb875eef71f303b28e096b22a8cd4b449d4 Reviewed-on: https://webrtc-review.googlesource.com/20222 Reviewed-by: Per Åhgren Commit-Queue: Henrik Lundin Cr-Commit-Position: refs/heads/master@{#20563} --- modules/audio_processing/include/audio_processing.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/audio_processing/include/audio_processing.h b/modules/audio_processing/include/audio_processing.h index dc6d9a1b9a..f3dc75b437 100644 --- a/modules/audio_processing/include/audio_processing.h +++ b/modules/audio_processing/include/audio_processing.h @@ -110,7 +110,7 @@ static const int kAgcStartupMinVolume = 85; #else static const int kAgcStartupMinVolume = 0; #endif // defined(WEBRTC_CHROMIUM_BUILD) -static constexpr int kClippedLevelMin = 170; +static constexpr int kClippedLevelMin = 70; struct ExperimentalAgc { ExperimentalAgc() = default; explicit ExperimentalAgc(bool enabled) : enabled(enabled) {}