From e381015ca0c1104edfd0688bcedff29b2e4eae07 Mon Sep 17 00:00:00 2001 From: hbos Date: Tue, 13 Dec 2016 02:35:19 -0800 Subject: [PATCH] Revert of New PeerConnectionInterface::GetStats: No bogus default implementation. (patchset #1 id:1 of https://codereview.webrtc.org/2566143002/ ) Reason for revert: Breaks google3 importer: http://webrtc-buildbot-master.mtv.corp.google.com:21000/builders/WebRTC%20google3%20Importer/builds/11260 Original issue's description: > New PeerConnectionInterface::GetStats: No bogus default implementation. > > The Chromium mock implementation implements the new GetStats API, so we > can remove this default implementation. > > BUG=chromium:627816 > > Committed: https://crrev.com/8f2309478da41cd8b829d022874dfd5ddc58551c > Cr-Commit-Position: refs/heads/master@{#15563} TBR=deadbeef@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:627816 Review-Url: https://codereview.webrtc.org/2575493002 Cr-Commit-Position: refs/heads/master@{#15567} --- webrtc/api/peerconnectioninterface.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/webrtc/api/peerconnectioninterface.h b/webrtc/api/peerconnectioninterface.h index 25c1d1bdfb..29badbd8bb 100644 --- a/webrtc/api/peerconnectioninterface.h +++ b/webrtc/api/peerconnectioninterface.h @@ -474,8 +474,10 @@ class PeerConnectionInterface : public rtc::RefCountInterface { StatsOutputLevel level) = 0; // Gets stats using the new stats collection API, see webrtc/api/stats/. These // will replace old stats collection API when the new API has matured enough. - // Master bug: crbug.com/627816 - virtual void GetStats(RTCStatsCollectorCallback* callback) = 0; + // TODO(hbos): Default implementation that does nothing only exists as to not + // break third party projects. As soon as they have been updated this should + // be changed to "= 0;". + virtual void GetStats(RTCStatsCollectorCallback* callback) {} virtual rtc::scoped_refptr CreateDataChannel( const std::string& label,