From e351560d5f4e3604b7c6d728047078c45ca75682 Mon Sep 17 00:00:00 2001 From: Jeremy Leconte Date: Wed, 18 Jan 2023 09:28:29 +0100 Subject: [PATCH] Disable RTCCameraVideoCapturerTestsWithMockedCaptureSession. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The test is already disabled on iOS < 16 and fails on iOS 16 with this error: /../../sdk/objc/unittests/RTCCameraVideoCapturerTests.mm:556: error: -[RTCCameraVideoCapturerTestsWithMockedCaptureSession testStartCaptureSetsOutputDimensionsInvalidPixelFormat] : ((width) equal to ([output.videoSettings[(id)kCVPixelBufferWidthKey] intValue])) failed: ("110") is not equal to ("0") https://chromium-swarm.appspot.com/task?id=5fc0ac239b2dd110 Change-Id: Ia0a5c4290261b204d5e369dfc62113268ef48127 Bug: webrtc:14829, b/264630045 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/290895 Commit-Queue: Kári Helgason Reviewed-by: Kári Helgason Cr-Commit-Position: refs/heads/main@{#39130} --- sdk/objc/unittests/RTCCameraVideoCapturerTests.mm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sdk/objc/unittests/RTCCameraVideoCapturerTests.mm b/sdk/objc/unittests/RTCCameraVideoCapturerTests.mm index 5018479157..7919878260 100644 --- a/sdk/objc/unittests/RTCCameraVideoCapturerTests.mm +++ b/sdk/objc/unittests/RTCCameraVideoCapturerTests.mm @@ -517,7 +517,8 @@ CMSampleBufferRef createTestSampleBufferRef() { XCTAssertEqual(callbackError, errorMock); } -- (void)testStartCaptureSetsOutputDimensionsInvalidPixelFormat { +// TODO(crbug.com/webrtc/14829): Test is disabled on iOS < 16 and broken on iOS 16. +- (void)DISABLED_testStartCaptureSetsOutputDimensionsInvalidPixelFormat { id expectedDeviceInputMock = OCMClassMock([AVCaptureDeviceInput class]); id captureDeviceInputMock = OCMClassMock([AVCaptureDeviceInput class]); OCMStub([captureDeviceInputMock deviceInputWithDevice:_deviceMock error:[OCMArg setTo:nil]])