From e2d829cf7731ab327435cd8e2b754dec98f7a6e9 Mon Sep 17 00:00:00 2001 From: Ali Tofigh Date: Wed, 10 Aug 2022 19:24:23 +0200 Subject: [PATCH] Remove unnecessary overload Bug: webrtc:13579 Change-Id: Ib8e9f3fb085718a140b5a6199cb75e7da22e4fe5 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271202 Commit-Queue: Ali Tofigh Reviewed-by: Ivo Creusen Cr-Commit-Position: refs/heads/main@{#37747} --- modules/audio_processing/include/audio_processing.h | 9 --------- modules/audio_processing/include/mock_audio_processing.h | 6 ------ 2 files changed, 15 deletions(-) diff --git a/modules/audio_processing/include/audio_processing.h b/modules/audio_processing/include/audio_processing.h index 9463130dc9..ff4a44b93c 100644 --- a/modules/audio_processing/include/audio_processing.h +++ b/modules/audio_processing/include/audio_processing.h @@ -623,15 +623,6 @@ class RTC_EXPORT AudioProcessing : public rtc::RefCountInterface { // return value of true indicates that the file has been // sucessfully opened, while a value of false indicates that // opening the file failed. - // - // TODO(webrtc:13579): Remove std::string version once downstream users have - // implemented the absl::string_view version. - virtual bool CreateAndAttachAecDump(const std::string& file_name, - int64_t max_log_size_bytes, - rtc::TaskQueue* worker_queue) { - return CreateAndAttachAecDump(absl::string_view(file_name), - max_log_size_bytes, worker_queue); - } virtual bool CreateAndAttachAecDump(absl::string_view file_name, int64_t max_log_size_bytes, rtc::TaskQueue* worker_queue) = 0; diff --git a/modules/audio_processing/include/mock_audio_processing.h b/modules/audio_processing/include/mock_audio_processing.h index a1d1b9401c..2ea1a865c3 100644 --- a/modules/audio_processing/include/mock_audio_processing.h +++ b/modules/audio_processing/include/mock_audio_processing.h @@ -151,12 +151,6 @@ class MockAudioProcessing : public AudioProcessing { MOCK_METHOD(void, set_stream_key_pressed, (bool key_pressed), (override)); MOCK_METHOD(void, set_stream_analog_level, (int), (override)); MOCK_METHOD(int, recommended_stream_analog_level, (), (const, override)); - MOCK_METHOD(bool, - CreateAndAttachAecDump, - (const std::string& file_name, - int64_t max_log_size_bytes, - rtc::TaskQueue* worker_queue), - (override)); MOCK_METHOD(bool, CreateAndAttachAecDump, (absl::string_view file_name,