admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove dependency on MessageHandlerAutoCleanup from BasicPortAllocatorSession and AllocationSequence

Browse Source 
All Post() calls are made to the network thread which the class already
clears up explicitly. 'AutoCleanup' scans all thread instances, which is
not needed for this class.

Bug: webrtc:11988
Change-Id: Ieefbdc87683dc62b6156c5df72e87d404242170f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194339
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32662}
This commit is contained in:
Tomas Gunnarsson 2020-11-21 15:20:33 +01:00 committed by Commit Bot
parent d96634781e
commit e27f3dea82
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
p2p/client/basic_port_allocator.h
View File

@ -106,9 +106,8 @@ enum class SessionState {
// process will be started.
};
class RTC_EXPORT BasicPortAllocatorSession
: public PortAllocatorSession,
public rtc::MessageHandlerAutoCleanup {
class RTC_EXPORT BasicPortAllocatorSession : public PortAllocatorSession,
public rtc::MessageHandler {
public:
BasicPortAllocatorSession(BasicPortAllocator* allocator,
const std::string& content_name,
@ -324,7 +323,7 @@ class TurnPort;
// Performs the allocation of ports, in a sequenced (timed) manner, for a given
// network and IP address.
class AllocationSequence : public rtc::MessageHandlerAutoCleanup,
class AllocationSequence : public rtc::MessageHandler,
public sigslot::has_slots<> {
public:
enum State {