From e252a12070e5b225cc8e85e1c556df43e79660f3 Mon Sep 17 00:00:00 2001 From: Maksim Ivanov Date: Tue, 14 Dec 2021 02:37:22 +0100 Subject: [PATCH] Fix use-after-move in RTCErrorOr Fix a use-after-move issue in RTCErrorOr, as found by clang-tidy: api/rtc_error.h:247: 'error' used after it was moved Bug: chromium:1122844 Change-Id: I9e826023618067ba37c2567b5e194c46db1dbd23 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/241200 Auto-Submit: Maksim Ivanov Reviewed-by: Taylor Brandstetter Commit-Queue: Taylor Brandstetter Cr-Commit-Position: refs/heads/main@{#35535} --- api/rtc_error.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/rtc_error.h b/api/rtc_error.h index 1376793a0b..42ceed18d9 100644 --- a/api/rtc_error.h +++ b/api/rtc_error.h @@ -244,7 +244,7 @@ class RTCErrorOr { // // REQUIRES: !error.ok(). This requirement is DCHECKed. RTCErrorOr(RTCError&& error) : error_(std::move(error)) { // NOLINT - RTC_DCHECK(!error.ok()); + RTC_DCHECK(!error_.ok()); } // Constructs a new RTCErrorOr with the given value. After calling this