From e21745a78b430ed4f2119b6342acbaa30a52b406 Mon Sep 17 00:00:00 2001 From: Jan Grulich Date: Mon, 3 Jul 2023 14:15:33 +0200 Subject: [PATCH] Video Capture PipeWire: initialize pw_stream raw pointer member We will not always initialize PipeWire stream when we fail early and in such case we will end up cleaning VideoCaptureModulePipeWire instance where we will attempt to free it even when it is not initialized. Bug: chromium:1457131 Change-Id: Id78310485aa5ae5d72c2d0d753dd5318b1b673ef Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/311261 Reviewed-by: Ilya Nikolaevskiy Commit-Queue: Jan Grulich Cr-Commit-Position: refs/heads/main@{#40390} --- modules/video_capture/linux/video_capture_pipewire.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/video_capture/linux/video_capture_pipewire.h b/modules/video_capture/linux/video_capture_pipewire.h index fe39f1dd92..316fb2449d 100644 --- a/modules/video_capture/linux/video_capture_pipewire.h +++ b/modules/video_capture/linux/video_capture_pipewire.h @@ -50,7 +50,7 @@ class VideoCaptureModulePipeWire : public VideoCaptureImpl { RTC_GUARDED_BY(capture_checker_); bool started_ RTC_GUARDED_BY(api_lock_); - struct pw_stream* stream_ RTC_GUARDED_BY(capture_checker_); + struct pw_stream* stream_ RTC_GUARDED_BY(capture_checker_) = nullptr; struct spa_hook stream_listener_ RTC_GUARDED_BY(capture_checker_); }; } // namespace videocapturemodule