admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delay the creation of the platform thread in TestAudioDeviceModule.

Browse Source 
This allows constructing TestAudioDeviceModule on a different thread
than the worker thread and avoids unnecessary invoke. Before,
thread->Start() would fail in a thread check.

Bug: b/79961243
Change-Id: I5c55d8feada2b0ae12bc121f3f795e76a8d04059
Reviewed-on: https://webrtc-review.googlesource.com/82941
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23574}
This commit is contained in:
Sami Kalliomäki 2018-06-11 15:28:33 +02:00 committed by Commit Bot
parent 9614a313b8
commit e1d617c266
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
modules/audio_device/include/test_audio_device.cc
View File

@ -61,10 +61,7 @@ class TestAudioDeviceModuleImpl
capturing_(false),
done_rendering_(true, true),
done_capturing_(true, true),
tick_(EventTimerWrapper::Create()),
thread_(TestAudioDeviceModuleImpl::Run,
this,
"TestAudioDeviceModuleImpl") {
tick_(EventTimerWrapper::Create()) {
auto good_sample_rate = [](int sr) {
return sr == 8000 || sr == 16000 || sr == 32000 || sr == 44100 ||
sr == 48000;
@ -84,13 +81,15 @@ class TestAudioDeviceModuleImpl
~TestAudioDeviceModuleImpl() {
StopPlayout();
StopRecording();
thread_.Stop();
thread_->Stop();
}
int32_t Init() {
RTC_CHECK(tick_->StartTimer(true, kFrameLengthMs / speed_));
thread_.Start();
thread_.SetPriority(rtc::kHighPriority);
thread_ = rtc::MakeUnique<rtc::PlatformThread>(
TestAudioDeviceModuleImpl::Run, this, "TestAudioDeviceModuleImpl");
thread_->Start();
thread_->SetPriority(rtc::kHighPriority);
return 0;
}
@ -212,7 +211,7 @@ class TestAudioDeviceModuleImpl
rtc::BufferT<int16_t> recording_buffer_ RTC_GUARDED_BY(lock_);
std::unique_ptr<EventTimerWrapper> tick_;
rtc::PlatformThread thread_;
std::unique_ptr<rtc::PlatformThread> thread_;
};
// A fake capturer that generates pulses with random samples between