From e1c4ed958da4a269e59263ca0531b64ee1fd95c7 Mon Sep 17 00:00:00 2001 From: "stefan@webrtc.org" Date: Wed, 27 Feb 2013 16:23:06 +0000 Subject: [PATCH] Fix to send a full NACK list at least roughly once every 1.5 x RTT. BUG=1434 Review URL: https://webrtc-codereview.appspot.com/1111007 git-svn-id: http://webrtc.googlecode.com/svn/trunk@3576 4adac7df-926f-26a2-2b94-8c16560cd09d --- webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc b/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc index 7867bde8d6..7eded947c7 100644 --- a/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc +++ b/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc @@ -1529,7 +1529,9 @@ WebRtc_Word32 ModuleRtpRtcpImpl::SendNACK(const WebRtc_UWord16* nack_list, WebRtc_UWord16 start_id = 0; if (nack_last_time_sent_ < time_limit) { - // Send list. + // Send list. Set the timer to make sure we only send a full NACK list once + // within every time_limit. + nack_last_time_sent_ = now; } else { // Only send if extended list. if (nack_last_seq_number_sent_ == nack_list[size - 1]) { @@ -1547,7 +1549,6 @@ WebRtc_Word32 ModuleRtpRtcpImpl::SendNACK(const WebRtc_UWord16* nack_list, nackLength = size - start_id; } } - nack_last_time_sent_ = now; nack_last_seq_number_sent_ = nack_list[size - 1]; switch (nack_method_) {