admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QualityScalingTest.AdaptsDownAndThenUpWithBalanced: fix for flaky test

Browse Source 
Bug: webrtc:14922
Change-Id: Ide460e78f00fcf59c8a5da66b431592f10512d94
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/299461
Commit-Queue: Åsa Persson <asapersson@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39745}
This commit is contained in:
Åsa Persson 2023-04-03 11:37:02 +02:00 committed by WebRTC LUCI CQ
parent 0587aaea1a
commit e0727118f1
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
video/quality_scaling_tests.cc
View File

@ -155,6 +155,15 @@ class ScalingObserver : public test::SendTest {
test_params_.size());
}
Action OnSendRtp(const uint8_t* packet, size_t length) override {
// The tests are expected to send at the configured start bitrate. Do not
// send any packets to avoid receiving REMB and possibly go down in target
// bitrate. A low bitrate estimate could result in downgrading due to other
// reasons than low/high QP-value (e.g. high frame drop percent) or not
// upgrading due to bitrate constraint.
return DROP_PACKET;
}
void PerformTest() override { EXPECT_EQ(expect_scaling_, Wait()); }
test::FunctionVideoEncoderFactory encoder_factory_;