From df6ecea8ac7c4c3bddeda089d5fb9eccdf38a0a6 Mon Sep 17 00:00:00 2001 From: Ivo Creusen Date: Wed, 29 Jun 2016 17:30:56 +0200 Subject: [PATCH] Fix to make the start/stop functions for the Rtc Eventlog non-virtual. This is needed to prevent the Chromium import bot from breaking. BUG= R=tommi@webrtc.org Review URL: https://codereview.webrtc.org/2107253002 . Cr-Commit-Position: refs/heads/master@{#13324} --- webrtc/api/peerconnectioninterface.h | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/webrtc/api/peerconnectioninterface.h b/webrtc/api/peerconnectioninterface.h index e57435559e..c72e2ec8af 100644 --- a/webrtc/api/peerconnectioninterface.h +++ b/webrtc/api/peerconnectioninterface.h @@ -494,11 +494,15 @@ class PeerConnectionInterface : public rtc::RefCountInterface { // operation fails the file will be closed. The logging will stop // automatically after 10 minutes have passed, or when the StopRtcEventLog // function is called. + // TODO(ivoc): Make this pure virtual when Chrome is updated. virtual bool StartRtcEventLog(rtc::PlatformFile file, - int64_t max_size_bytes) = 0; + int64_t max_size_bytes) { + return false; + } // Stops logging the RtcEventLog. - virtual void StopRtcEventLog() = 0; + // TODO(ivoc): Make this pure virtual when Chrome is updated. + virtual void StopRtcEventLog() {} // Terminates all media and closes the transport. virtual void Close() = 0;