From de83d0c81a4fa29e32a7e62b37a673cdb386458e Mon Sep 17 00:00:00 2001 From: Artem Titov Date: Mon, 1 Apr 2019 15:03:46 +0200 Subject: [PATCH] Fix params comments in network emulation layer and its usage in scenario framework Bug: webrtc:10138 Change-Id: I9273410375cf4914abffa69f7443e13d52e77675 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/130222 Commit-Queue: Artem Titov Reviewed-by: Mirko Bonadei Cr-Commit-Position: refs/heads/master@{#27397} --- test/scenario/network_node.cc | 2 +- test/scenario/scenario.cc | 4 ++-- test/scenario/simulated_time.cc | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/test/scenario/network_node.cc b/test/scenario/network_node.cc index 40b1836dc5..be9ca71664 100644 --- a/test/scenario/network_node.cc +++ b/test/scenario/network_node.cc @@ -201,7 +201,7 @@ void CrossTrafficSource::Process(Timestamp at_time, TimeDelta delta) { pending_size_ += TrafficRate() * delta; if (pending_size_ > config_.min_packet_size) { target_->OnPacketReceived(EmulatedIpPacket( - rtc::SocketAddress() /*from*/, receiver_address_, + /*from=*/rtc::SocketAddress(), receiver_address_, rtc::CopyOnWriteBuffer(pending_size_.bytes()), at_time)); pending_size_ = DataSize::Zero(); } diff --git a/test/scenario/scenario.cc b/test/scenario/scenario.cc index 1554e298ce..6abc5d5210 100644 --- a/test/scenario/scenario.cc +++ b/test/scenario/scenario.cc @@ -221,7 +221,7 @@ void Scenario::TriggerPacketBurst(std::vector over_nodes, EmulatedNetworkNode::CreateRoute(route_ip, over_nodes, &null_receiver_); for (size_t i = 0; i < num_packets; ++i) over_nodes[0]->OnPacketReceived(EmulatedIpPacket( - rtc::SocketAddress() /*from*/, rtc::SocketAddress(route_ip, 0) /*to*/, + /*from=*/rtc::SocketAddress(), /*to=*/rtc::SocketAddress(route_ip, 0), rtc::CopyOnWriteBuffer(packet_size), Now())); } @@ -234,7 +234,7 @@ void Scenario::NetworkDelayedAction( EmulatedNetworkNode::CreateRoute(route_ip, over_nodes, action_receivers_.back().get()); over_nodes[0]->OnPacketReceived(EmulatedIpPacket( - rtc::SocketAddress() /*from*/, rtc::SocketAddress(route_ip, 0) /*to*/, + /*from=*/rtc::SocketAddress(), /*to=*/rtc::SocketAddress(route_ip, 0), rtc::CopyOnWriteBuffer(packet_size), Now())); } diff --git a/test/scenario/simulated_time.cc b/test/scenario/simulated_time.cc index f808c3a004..0d01385f83 100644 --- a/test/scenario/simulated_time.cc +++ b/test/scenario/simulated_time.cc @@ -331,7 +331,7 @@ void SimulatedTimeClient::PacerProcess(Timestamp at_time) { ProcessFrames(at_time); for (const auto& to_send : sender_.PaceAndPullSendPackets(at_time)) { sender_.send_node_->OnPacketReceived(EmulatedIpPacket( - rtc::SocketAddress() /*from*/, sender_.send_receiver_address_, + /*from=*/rtc::SocketAddress(), sender_.send_receiver_address_, to_send.data, at_time)); Update(congestion_controller_->OnSentPacket(to_send.send_info)); }