From ddebc17beef1ebf66464182665e4cb1cec864ee7 Mon Sep 17 00:00:00 2001 From: "elham@webrtc.org" Date: Thu, 13 Dec 2012 21:55:47 +0000 Subject: [PATCH] Fix for buffer overflow, WebRTC issue 1196 Review URL: https://webrtc-codereview.appspot.com/998004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@3286 4adac7df-926f-26a2-2b94-8c16560cd09d --- .../test/auto_test/primitives/choice_helpers.cc | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/webrtc/video_engine/test/auto_test/primitives/choice_helpers.cc b/webrtc/video_engine/test/auto_test/primitives/choice_helpers.cc index bdec0aefb7..d923e964bd 100644 --- a/webrtc/video_engine/test/auto_test/primitives/choice_helpers.cc +++ b/webrtc/video_engine/test/auto_test/primitives/choice_helpers.cc @@ -14,6 +14,7 @@ #include #include #include +#include namespace webrtc { @@ -53,9 +54,9 @@ std::string ChoiceBuilder::MakeHumanReadableOptions() { std::string result = ""; Choices::const_iterator iterator = choices_.begin(); for (int number = 1; iterator != choices_.end(); ++iterator, ++number) { - char buffer[128]; - sprintf(buffer, "\n %d. %s", number, (*iterator).c_str()); - result += buffer; + std::ostringstream os; + os << "\n " << number << ". " << (*iterator).c_str(); + result += os.str(); } return result; }