From dcc95081e1e9d7ab95206a912305d3836fbdfba6 Mon Sep 17 00:00:00 2001 From: Danil Chapovalov Date: Fri, 15 Mar 2024 12:36:56 +0100 Subject: [PATCH] Cleanup QualityAnalyzingVideoEncoderFactory::CreateVideoEncoder And thus require Environment to be propagated to this test helper Bug: webrtc:15860 Change-Id: Ia4796d7a6a8e6f5dcb947899617df43e991419e7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/343181 Reviewed-by: Jeremy Leconte Commit-Queue: Danil Chapovalov Cr-Commit-Position: refs/heads/main@{#41910} --- .../e2e/analyzer/video/quality_analyzing_video_encoder.cc | 8 -------- .../e2e/analyzer/video/quality_analyzing_video_encoder.h | 2 -- 2 files changed, 10 deletions(-) diff --git a/test/pc/e2e/analyzer/video/quality_analyzing_video_encoder.cc b/test/pc/e2e/analyzer/video/quality_analyzing_video_encoder.cc index b5dca40a33..7ecfa70f97 100644 --- a/test/pc/e2e/analyzer/video/quality_analyzing_video_encoder.cc +++ b/test/pc/e2e/analyzer/video/quality_analyzing_video_encoder.cc @@ -403,14 +403,6 @@ QualityAnalyzingVideoEncoderFactory::QueryCodecSupport( return delegate_->QueryCodecSupport(format, scalability_mode); } -std::unique_ptr -QualityAnalyzingVideoEncoderFactory::CreateVideoEncoder( - const SdpVideoFormat& format) { - return std::make_unique( - peer_name_, delegate_->CreateVideoEncoder(format), bitrate_multiplier_, - stream_to_sfu_config_, injector_, analyzer_); -} - std::unique_ptr QualityAnalyzingVideoEncoderFactory::Create( const Environment& env, const SdpVideoFormat& format) { diff --git a/test/pc/e2e/analyzer/video/quality_analyzing_video_encoder.h b/test/pc/e2e/analyzer/video/quality_analyzing_video_encoder.h index 338afaa156..1fb63023dd 100644 --- a/test/pc/e2e/analyzer/video/quality_analyzing_video_encoder.h +++ b/test/pc/e2e/analyzer/video/quality_analyzing_video_encoder.h @@ -177,8 +177,6 @@ class QualityAnalyzingVideoEncoderFactory : public VideoEncoderFactory { VideoEncoderFactory::CodecSupport QueryCodecSupport( const SdpVideoFormat& format, absl::optional scalability_mode) const override; - std::unique_ptr CreateVideoEncoder( - const SdpVideoFormat& format) override; std::unique_ptr Create(const Environment& env, const SdpVideoFormat& format) override;