From daf88b1cbf878af0071cfd7942ea4c65322f87ba Mon Sep 17 00:00:00 2001 From: deadbeef Date: Wed, 5 Oct 2016 22:29:30 -0700 Subject: [PATCH] Removing ERROR message for something that's expected to occur. This error occurred if you created a data channel before there's a data m= section. But this is expected to happen, since creating a data channel is how you get a data m= section in the first place. BUG=chromium:579430 NOTRY=true TBR=pthatcher@webrtc.org Review-Url: https://codereview.webrtc.org/2396013002 Cr-Commit-Position: refs/heads/master@{#14537} --- webrtc/api/webrtcsession.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/webrtc/api/webrtcsession.cc b/webrtc/api/webrtcsession.cc index df4a48a7aa..ded3023653 100644 --- a/webrtc/api/webrtcsession.cc +++ b/webrtc/api/webrtcsession.cc @@ -1274,7 +1274,9 @@ bool WebRtcSession::SendData(const cricket::SendDataParams& params, bool WebRtcSession::ConnectDataChannel(DataChannel* webrtc_data_channel) { if (!data_channel_) { - LOG(LS_ERROR) << "ConnectDataChannel called when data_channel_ is NULL."; + // Don't log an error here, because DataChannels are expected to call + // ConnectDataChannel in this state. It's the only way to initially tell + // whether or not the underlying transport is ready. return false; } data_channel_->SignalReadyToSendData.connect(webrtc_data_channel,