From daac58290e0f171d221d66ff6d86987a00b3e2cb Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Wed, 8 May 2019 16:27:23 +0200 Subject: [PATCH] Remove -Wno-undef and -Wno-extra-semi. These issues have been fixed upstream in Abseil. Bug: webrtc:10138 Change-Id: Ic0ebd22d0ad95bbd5269c08c182a76f9bf42f3a2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/135571 Reviewed-by: Artem Titov Commit-Queue: Mirko Bonadei Cr-Commit-Position: refs/heads/master@{#27883} --- test/pc/e2e/BUILD.gn | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/test/pc/e2e/BUILD.gn b/test/pc/e2e/BUILD.gn index e0da5b89f2..0c5f36e37e 100644 --- a/test/pc/e2e/BUILD.gn +++ b/test/pc/e2e/BUILD.gn @@ -161,17 +161,6 @@ rtc_source_set("quality_analyzing_video_encoder") { ] } -# TODO(mbonadei): Remove as soon as -Wundef and -Wextra-semi problems are -# fixed upstream (CLs are under review). -config("peerconnection_quality_test_cflags") { - if (is_clang) { - cflags = [ - "-Wno-undef", - "-Wno-extra-semi", - ] - } -} - if (rtc_include_tests) { rtc_source_set("video_quality_analyzer_injection_helper") { visibility = [ "*" ] @@ -236,9 +225,6 @@ if (rtc_include_tests) { visibility = [ "*" ] testonly = true - # TODO(mbonadei): Remove as soon as -Wundef and -Wextra-semi problems are - # fixed upstream (CLs are under review). - configs += [ ":peerconnection_quality_test_cflags" ] sources = [ "peer_connection_quality_test.cc", "peer_connection_quality_test.h", @@ -323,9 +309,6 @@ if (rtc_include_tests) { rtc_source_set("peer_connection_e2e_smoke_test") { testonly = true - # TODO(mbonadei): Remove as soon as -Wundef and -Wextra-semi problems are - # fixed upstream (CLs are under review). - configs += [ ":peerconnection_quality_test_cflags" ] sources = [ "peer_connection_e2e_smoke_test.cc", ] @@ -434,9 +417,6 @@ rtc_source_set("example_video_quality_analyzer") { rtc_source_set("default_video_quality_analyzer") { visibility = [ "*" ] - # TODO(mbonadei): Remove as soon as -Wundef and -Wextra-semi problems are - # fixed upstream (CLs are under review). - configs += [ ":peerconnection_quality_test_cflags" ] testonly = true sources = [ "analyzer/video/default_video_quality_analyzer.cc",