From da357a9495b07014dea2e2daceb6b68ed3232701 Mon Sep 17 00:00:00 2001 From: Tommi Date: Mon, 18 May 2020 14:26:08 +0200 Subject: [PATCH] Rename EchoPathDelayEstimator to EchoPathDelayEstimatorDeathTest. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ...for the NullDataDumper, WrongCaptureBlockSize and DISABLED_WrongRenderBlockSize tests. This is to avoid creation of additional threads on Mac, which can cause issues on asan bots. Bug: webrtc:11577 Change-Id: I4e6a64d47ec3b0a0e0018b19a0486208ba7e6ae2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175600 Reviewed-by: Per Åhgren Reviewed-by: Mirko Bonadei Commit-Queue: Tommi Cr-Commit-Position: refs/heads/master@{#31307} --- .../aec3/echo_path_delay_estimator_unittest.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/audio_processing/aec3/echo_path_delay_estimator_unittest.cc b/modules/audio_processing/aec3/echo_path_delay_estimator_unittest.cc index 8003a11bbc..6ba4cdd0d7 100644 --- a/modules/audio_processing/aec3/echo_path_delay_estimator_unittest.cc +++ b/modules/audio_processing/aec3/echo_path_delay_estimator_unittest.cc @@ -165,7 +165,7 @@ TEST(EchoPathDelayEstimator, NoDelayEstimatesForLowLevelRenderSignals) { // Verifies the check for the render blocksize. // TODO(peah): Re-enable the test once the issue with memory leaks during DEATH // tests on test bots has been fixed. -TEST(EchoPathDelayEstimator, DISABLED_WrongRenderBlockSize) { +TEST(EchoPathDelayEstimatorDeathTest, DISABLED_WrongRenderBlockSize) { ApmDataDumper data_dumper(0); EchoCanceller3Config config; EchoPathDelayEstimator estimator(&data_dumper, config, 1); @@ -180,7 +180,7 @@ TEST(EchoPathDelayEstimator, DISABLED_WrongRenderBlockSize) { // Verifies the check for the capture blocksize. // TODO(peah): Re-enable the test once the issue with memory leaks during DEATH // tests on test bots has been fixed. -TEST(EchoPathDelayEstimator, WrongCaptureBlockSize) { +TEST(EchoPathDelayEstimatorDeathTest, WrongCaptureBlockSize) { ApmDataDumper data_dumper(0); EchoCanceller3Config config; EchoPathDelayEstimator estimator(&data_dumper, config, 1); @@ -194,7 +194,7 @@ TEST(EchoPathDelayEstimator, WrongCaptureBlockSize) { } // Verifies the check for non-null data dumper. -TEST(EchoPathDelayEstimator, NullDataDumper) { +TEST(EchoPathDelayEstimatorDeathTest, NullDataDumper) { EXPECT_DEATH(EchoPathDelayEstimator(nullptr, EchoCanceller3Config(), 1), ""); }