From da250064312d4ad6404ac962fc0ef33b6359bb72 Mon Sep 17 00:00:00 2001 From: ossu Date: Mon, 23 Jan 2017 07:37:43 -0800 Subject: [PATCH] Fixed public_deps for libjingle_peerconnection{,_api} https://codereview.webrtc.org/2514883002/ changed and moved these targets around but did not add public dependencies for the fallbacks, which causes gn gen --check a lot of anger. NOTRY=true # Only build changes and windows bots are cranky atm. BUG=webrtc:5806 Review-Url: https://codereview.webrtc.org/2651663002 Cr-Commit-Position: refs/heads/master@{#16214} --- webrtc/api/BUILD.gn | 2 +- webrtc/pc/BUILD.gn | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/webrtc/api/BUILD.gn b/webrtc/api/BUILD.gn index 9d893e0c01..af49219e46 100644 --- a/webrtc/api/BUILD.gn +++ b/webrtc/api/BUILD.gn @@ -88,7 +88,7 @@ rtc_static_library("libjingle_peerconnection_api") { # TODO(ossu): Remove once downstream projects have updated. rtc_source_set("libjingle_peerconnection") { - deps = [ + public_deps = [ "../pc:libjingle_peerconnection", ] } diff --git a/webrtc/pc/BUILD.gn b/webrtc/pc/BUILD.gn index 5c4d87c677..d447db743a 100644 --- a/webrtc/pc/BUILD.gn +++ b/webrtc/pc/BUILD.gn @@ -146,13 +146,16 @@ rtc_static_library("libjingle_peerconnection") { deps = [ ":rtc_pc", "../api:call_api", - "../api:libjingle_peerconnection_api", "../api:rtc_stats_api", "../call", "../media", "../stats", ] + public_deps = [ + "../api:libjingle_peerconnection_api", + ] + if (rtc_use_quic) { sources += [ "quicdatachannel.cc",