From d9c51142bd012eb92e8a85d1201f4221ec83441a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Per=20=C3=85hgren?= Date: Fri, 3 Apr 2020 15:46:52 +0200 Subject: [PATCH] AEC3: Add additional transparency-related killswitches MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This CL adds two kill-switches to the AEC3 code to be used as safe fallbacks to increase AEC transparency. The changes have been shown to be bitexact for a test dataset. Bug: webrtc:11487,chromium:1067597 Change-Id: I7f9f78db4964990bcdfa9adae6ef36a56bce7224 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/172840 Reviewed-by: Sam Zackrisson Commit-Queue: Per Åhgren Cr-Commit-Position: refs/heads/master@{#30998} --- modules/audio_processing/aec3/echo_canceller3.cc | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/modules/audio_processing/aec3/echo_canceller3.cc b/modules/audio_processing/aec3/echo_canceller3.cc index 95cd22a6ea..f4be7a499c 100644 --- a/modules/audio_processing/aec3/echo_canceller3.cc +++ b/modules/audio_processing/aec3/echo_canceller3.cc @@ -164,6 +164,18 @@ EchoCanceller3Config AdjustConfig(const EchoCanceller3Config& config) { adjusted_cfg.suppressor.nearend_tuning.mask_lf.enr_suppress = 1.3f; } + if (field_trial::IsEnabled( + "WebRTC-Aec3EnforceMoreTransparentNormalSuppressorHfTuning")) { + adjusted_cfg.suppressor.normal_tuning.mask_hf.enr_transparent = 0.3f; + adjusted_cfg.suppressor.normal_tuning.mask_hf.enr_suppress = 0.4f; + } + + if (field_trial::IsEnabled( + "WebRTC-Aec3EnforceMoreTransparentNearendSuppressorHfTuning")) { + adjusted_cfg.suppressor.nearend_tuning.mask_hf.enr_transparent = 1.09f; + adjusted_cfg.suppressor.nearend_tuning.mask_hf.enr_suppress = 1.1f; + } + if (field_trial::IsEnabled( "WebRTC-Aec3EnforceRapidlyAdjustingNormalSuppressorTunings")) { adjusted_cfg.suppressor.normal_tuning.max_inc_factor = 2.5f;