admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

RTCIceCandidatePairStats.requestsReceived defined by RTCStatsCollector.

Browse Source 
Spec: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-requestsreceived

BUG=chromium:633550

Review-Url: https://codereview.webrtc.org/2565463002
Cr-Commit-Position: refs/heads/master@{#15506}
This commit is contained in:
hbos 2016-12-09 04:12:39 -08:00 committed by Commit bot
parent 33ce88926a
commit d82f5125b7
4 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
webrtc/api/rtcstats_integrationtest.cc
View File

@ -338,7 +338,7 @@ class RTCStatsReportVerifier {
verifier.TestMemberIsDefined(candidate_pair.current_rtt);
verifier.TestMemberIsUndefined(candidate_pair.available_outgoing_bitrate);
verifier.TestMemberIsUndefined(candidate_pair.available_incoming_bitrate);
verifier.TestMemberIsUndefined(candidate_pair.requests_received);
verifier.TestMemberIsDefined(candidate_pair.requests_received);
verifier.TestMemberIsDefined(candidate_pair.requests_sent);
verifier.TestMemberIsDefined(candidate_pair.responses_received);
verifier.TestMemberIsDefined(candidate_pair.responses_sent);

2
webrtc/api/rtcstatscollector.cc
View File

@ -634,6 +634,8 @@ void RTCStatsCollector::ProduceIceCandidateAndPairStats_s(
// https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-currentrtt
candidate_pair_stats->current_rtt =
static_cast<double>(info.rtt) / rtc::kNumMillisecsPerSec;
candidate_pair_stats->requests_received =
static_cast<uint64_t>(info.recv_ping_requests);
candidate_pair_stats->requests_sent =
static_cast<uint64_t>(info.sent_ping_requests_total);
candidate_pair_stats->responses_received =

2
webrtc/api/rtcstatscollector_unittest.cc
View File

@ -1005,6 +1005,7 @@ TEST_F(RTCStatsCollectorTest, CollectRTCIceCandidatePairStats) {
connection_info.sent_total_bytes = 42;
connection_info.recv_total_bytes = 1234;
connection_info.rtt = 1337;
connection_info.recv_ping_requests = 2020;
connection_info.sent_ping_requests_total = 1010;
connection_info.recv_ping_responses = 4321;
connection_info.sent_ping_responses = 1000;
@ -1039,6 +1040,7 @@ TEST_F(RTCStatsCollectorTest, CollectRTCIceCandidatePairStats) {
expected_pair.bytes_sent = 42;
expected_pair.bytes_received = 1234;
expected_pair.current_rtt = 1.337;
expected_pair.requests_received = 2020;
expected_pair.requests_sent = 1010;
expected_pair.responses_received = 4321;
expected_pair.responses_sent = 1000;

1
webrtc/api/stats/rtcstats_objects.h
View File

@ -142,7 +142,6 @@ class RTCIceCandidatePairStats final : public RTCStats {
RTCStatsMember<double> available_outgoing_bitrate;
// TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/633550
RTCStatsMember<double> available_incoming_bitrate;
// TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/633550
RTCStatsMember<uint64_t> requests_received;
RTCStatsMember<uint64_t> requests_sent;
RTCStatsMember<uint64_t> responses_received;