admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove global MetricsLoggerAndExporter instance in favor of MetricsLogger

Browse Source 
Bug: b/246095034
Change-Id: Ie3dd5947f0f593bd17cfecfa333d5254fa40769d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276628
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38190}
This commit is contained in:
Artem Titov 2022-09-25 00:39:30 +02:00 committed by WebRTC LUCI CQ
parent 3100e5724f
commit d7dbe7fda8
2 changed files with 0 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
api/test/metrics/global_metrics_logger_and_exporter.cc
View File

@ -21,11 +21,6 @@
namespace webrtc {
namespace test {
namespace {
MetricsLoggerAndExporter* global_metrics_logger_and_exporter = nullptr;
} // namespace
MetricsLogger* GetGlobalMetricsLogger() {
static MetricsLogger* logger_ =
@ -44,21 +39,5 @@ bool ExportPerfMetric(MetricsLogger& logger,
return success;
}
MetricsLoggerAndExporter* GetGlobalMetricsLoggerAndExporter() {
return global_metrics_logger_and_exporter;
}
void SetupGlobalMetricsLoggerAndExporter(
std::vector<std::unique_ptr<MetricsExporter>> exporters) {
RTC_CHECK(global_metrics_logger_and_exporter == nullptr);
global_metrics_logger_and_exporter = new MetricsLoggerAndExporter(
Clock::GetRealTimeClock(), std::move(exporters));
}
void ExportAndDestroyGlobalMetricsLoggerAndExporter() {
RTC_CHECK(global_metrics_logger_and_exporter != nullptr);
delete global_metrics_logger_and_exporter;
}
} // namespace test
} // namespace webrtc

14
api/test/metrics/global_metrics_logger_and_exporter.h
View File

@ -26,20 +26,6 @@ MetricsLogger* GetGlobalMetricsLogger();
bool ExportPerfMetric(MetricsLogger& logger,
std::vector<std::unique_ptr<MetricsExporter>> exporters);
// Returns current global `MetricsLoggerAndExporter`. Returns `nullptr` if there
// is global instance wasn't initialized.
MetricsLoggerAndExporter* GetGlobalMetricsLoggerAndExporter();
// Initialize global `MetricsLoggerAndExporter` with provided vector of
// exporters. Crashes if there is already initialized global instance.
void SetupGlobalMetricsLoggerAndExporter(
std::vector<std::unique_ptr<MetricsExporter>> exporters);
// Destroys global `MetricsLoggerAndExporter` forcing it to export all collected
// metrics to the configured exporters. Crashes if there is no initialized
// global instance.
void ExportAndDestroyGlobalMetricsLoggerAndExporter();
} // namespace test
} // namespace webrtc