admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[DVQA] Remove default value for report_infra_metrics in VideoQualityAnalyzerInjectionHelper

Browse Source 
Bug: None
Change-Id: Ifa13844e0c7942c2418cb5bd29e5d8f03b9528c6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/290720
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39056}
This commit is contained in:
Artem Titov 2023-01-09 15:39:15 +01:00 committed by WebRTC LUCI CQ
parent 854ca9a0a6
commit d7956891d0
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
test/pc/e2e/analyzer/video/video_quality_analyzer_injection_helper.h
View File

@ -78,11 +78,10 @@ class VideoQualityAnalyzerInjectionHelper : public StatsObserverInterface {
// TODO(titovartem): Remove method with `peer_name` only parameter. // TODO(titovartem): Remove method with `peer_name` only parameter.
std::unique_ptr<rtc::VideoSinkInterface<VideoFrame>> CreateVideoSink( std::unique_ptr<rtc::VideoSinkInterface<VideoFrame>> CreateVideoSink(
absl::string_view peer_name); absl::string_view peer_name);
// TODO(titovartem): Remove default value for `report_infra_metrics`.
std::unique_ptr<AnalyzingVideoSink> CreateVideoSink( std::unique_ptr<AnalyzingVideoSink> CreateVideoSink(
absl::string_view peer_name, absl::string_view peer_name,
const VideoSubscription& subscription, const VideoSubscription& subscription,
bool report_infra_metrics = false); bool report_infra_metrics);
void Start(std::string test_case_name, void Start(std::string test_case_name,
rtc::ArrayView<const std::string> peer_names, rtc::ArrayView<const std::string> peer_names,