admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete MediaTransport method SetNetworkChangeCallback

Browse Source 
Followup to https://webrtc-review.googlesource.com/c/src/+/121460.

Bug: webrtc:9719
Change-Id: I6261c450379de22d916f4048fec89e5e67e300f8
Reviewed-on: https://webrtc-review.googlesource.com/c/121651
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Peter Slatala <psla@webrtc.org>
Commit-Queue: Peter Slatala <psla@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26576}
This commit is contained in:
Niels Möller 2019-02-06 17:36:29 +01:00 committed by Commit Bot
parent fe6e50f0af
commit d70a1148ae
3 changed files with 4 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
api/DEPS
View File

@ -111,7 +111,6 @@ specific_include_rules = {
"media_transport_interface\.h": [
"+rtc_base/copy_on_write_buffer.h", # As used by datachannelinterface.h
"+rtc_base/network_route.h",
"+rtc_base/deprecation.h",
],
"peer_connection_factory_proxy\.h": [

3
api/media_transport_interface.cc
View File

@ -154,9 +154,6 @@ MediaTransportInterface::GetLatestTargetTransferRate() {
return absl::nullopt;
}
void MediaTransportInterface::SetNetworkChangeCallback(
MediaTransportNetworkChangeCallback* callback) {}
void MediaTransportInterface::AddNetworkChangeCallback(
MediaTransportNetworkChangeCallback* callback) {}

15
api/media_transport_interface.h
View File

@ -29,7 +29,6 @@
#include "api/units/data_rate.h"
#include "api/video/encoded_image.h"
#include "rtc_base/copy_on_write_buffer.h"
#include "rtc_base/deprecation.h"
#include "rtc_base/network_route.h"
namespace rtc {
@ -429,16 +428,10 @@ class MediaTransportInterface {
// might not be a very accurate number.
virtual size_t GetAudioPacketOverhead() const;
// Sets an observer for network change events. If the network route is already
// established when the callback is set, |callback| will be called immediately
// with the current network route.
// Before media transport is destroyed, the callback must be unregistered by
// setting it to nullptr.
// TODO(nisse): The SetNetworkChangeCallback is being replaced with Add/Remove
// methods, because both video channel and voice channel need to register.
RTC_DEPRECATED
virtual void SetNetworkChangeCallback(
MediaTransportNetworkChangeCallback* callback);
// Registers an observer for network change events. If the network route is
// already established when the callback is added, |callback| will be called
// immediately with the current network route. Before media transport is
// destroyed, the callback must be removed.
virtual void AddNetworkChangeCallback(
MediaTransportNetworkChangeCallback* callback);
virtual void RemoveNetworkChangeCallback(