admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Cleans up WebRTC-Pacer-SmallFirstProbePacket flag

Browse Source 
Bug: None
Change-Id: I535e18a5f1eabea2c24c17bc42602689f356c647
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/196362
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32776}
This commit is contained in:
Erik Språng 2020-12-03 16:34:05 +01:00 committed by Commit Bot
parent 397c40e2a4
commit d708677d7a
2 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
modules/pacing/pacing_controller.cc
View File

@ -112,8 +112,6 @@ PacingController::PacingController(Clock* clock,
send_padding_if_silent_(
IsEnabled(*field_trials_, "WebRTC-Pacer-PadInSilence")),
pace_audio_(IsEnabled(*field_trials_, "WebRTC-Pacer-BlockAudio")),
small_first_probe_packet_(
!IsDisabled(*field_trials_, "WebRTC-Pacer-SmallFirstProbePacket")),
ignore_transport_overhead_(
IsEnabled(*field_trials_, "WebRTC-Pacer-IgnoreTransportOverhead")),
padding_target_duration_(GetDynamicPaddingTarget(*field_trials_)),
@ -519,7 +517,7 @@ void PacingController::ProcessPackets() {
// The paused state is checked in the loop since it leaves the critical
// section allowing the paused state to be changed from other code.
while (!paused_) {
if (small_first_probe_packet_ && first_packet_in_probe) {
if (first_packet_in_probe) {
// If first packet in probe, insert a small padding packet so we have a
// more reliable start window for the rate estimation.
auto padding = packet_sender_->GeneratePadding(DataSize::Bytes(1));

1
modules/pacing/pacing_controller.h
View File

@ -182,7 +182,6 @@ class PacingController {
const bool drain_large_queues_;
const bool send_padding_if_silent_;
const bool pace_audio_;
const bool small_first_probe_packet_;
const bool ignore_transport_overhead_;
// In dynamic mode, indicates the target size when requesting padding,
// expressed as a duration in order to adjust for varying padding rate.