diff --git a/.gn b/.gn index e151f7cdc3..8a173ba495 100644 --- a/.gn +++ b/.gn @@ -19,7 +19,10 @@ secondary_source = "//build/secondary/" # their includes checked for proper dependencies when you run either # "gn check" or "gn gen --check". # TODO(kjellander): Keep adding paths to this list as work in webrtc:5589 is done. -check_targets = [ "//webrtc/voice_engine:level_indicator" ] +check_targets = [ + "//webrtc/voice_engine:level_indicator", + "//webrtc/modules/audio_mixer:audio_conference_mixer", +] # These are the list of GN files that run exec_script. This whitelist exists # to force additional review for new uses of exec_script, which is strongly diff --git a/webrtc/modules/audio_mixer/BUILD.gn b/webrtc/modules/audio_mixer/BUILD.gn index 7ef27908be..2449c54979 100644 --- a/webrtc/modules/audio_mixer/BUILD.gn +++ b/webrtc/modules/audio_mixer/BUILD.gn @@ -72,9 +72,11 @@ source_set("audio_conference_mixer") { } deps = [ + "../..:webrtc_common", "../../base:rtc_base_approved", "../../modules/audio_processing", "../../modules/utility", "../../system_wrappers", + "../../system_wrappers:system_wrappers_default", ] } diff --git a/webrtc/modules/audio_mixer/new_audio_conference_mixer_impl.cc b/webrtc/modules/audio_mixer/new_audio_conference_mixer_impl.cc index 5be76ec4d0..48380fc550 100644 --- a/webrtc/modules/audio_mixer/new_audio_conference_mixer_impl.cc +++ b/webrtc/modules/audio_mixer/new_audio_conference_mixer_impl.cc @@ -19,7 +19,6 @@ #include "webrtc/modules/utility/include/audio_frame_operations.h" #include "webrtc/system_wrappers/include/critical_section_wrapper.h" #include "webrtc/system_wrappers/include/trace.h" -#include "webrtc/voice_engine/utility.h" namespace webrtc { namespace { @@ -142,6 +141,8 @@ NewAudioConferenceMixerImpl::NewAudioConferenceMixerImpl(int id) thread_checker_.DetachFromThread(); } +NewAudioConferenceMixerImpl::~NewAudioConferenceMixerImpl() {} + bool NewAudioConferenceMixerImpl::Init() { crit_.reset(CriticalSectionWrapper::CreateCriticalSection()); if (crit_.get() == NULL) diff --git a/webrtc/modules/audio_mixer/new_audio_conference_mixer_impl.h b/webrtc/modules/audio_mixer/new_audio_conference_mixer_impl.h index ef93e6ff91..3933350fed 100644 --- a/webrtc/modules/audio_mixer/new_audio_conference_mixer_impl.h +++ b/webrtc/modules/audio_mixer/new_audio_conference_mixer_impl.h @@ -19,7 +19,6 @@ #include "webrtc/base/thread_checker.h" #include "webrtc/engine_configurations.h" #include "webrtc/modules/audio_mixer/new_audio_conference_mixer.h" -#include "webrtc/modules/audio_conference_mixer/source/memory_pool.h" #include "webrtc/modules/include/module_common_types.h" namespace webrtc { @@ -64,6 +63,8 @@ class NewAudioConferenceMixerImpl : public NewAudioConferenceMixer { explicit NewAudioConferenceMixerImpl(int id); + ~NewAudioConferenceMixerImpl() override; + // Must be called after ctor. bool Init();