From d6b9d3353db7fb09df4fd515aa7d0cf6bf5a47cf Mon Sep 17 00:00:00 2001 From: henrika Date: Thu, 5 Nov 2015 12:44:24 +0100 Subject: [PATCH] Moves logging of audio effects to when they are enabled BUG=none TBR=magjed Review URL: https://codereview.webrtc.org/1411783011 . Cr-Commit-Position: refs/heads/master@{#10516} --- .../voiceengine/WebRtcAudioEffects.java | 20 ++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioEffects.java b/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioEffects.java index 9b90f4ab54..7cd769a63c 100644 --- a/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioEffects.java +++ b/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioEffects.java @@ -208,15 +208,6 @@ class WebRtcAudioEffects { private WebRtcAudioEffects() { Logging.d(TAG, "ctor" + WebRtcAudioUtils.getThreadInfo()); - for (Descriptor d : AudioEffect.queryEffects()) { - if (effectTypeIsVoIP(d.type) || DEBUG) { - // Only log information for VoIP effects (AEC, AEC and NS). - Logging.d(TAG, "name: " + d.name + ", " - + "mode: " + d.connectMode + ", " - + "implementor: " + d.implementor + ", " - + "UUID: " + d.uuid); - } - } } // Call this method to enable or disable the platform AEC. It modifies @@ -282,6 +273,17 @@ class WebRtcAudioEffects { assertTrue(agc == null); assertTrue(ns == null); + // Add logging of supported effects but filter out "VoIP effects", i.e., + // AEC, AEC and NS. + for (Descriptor d : AudioEffect.queryEffects()) { + if (effectTypeIsVoIP(d.type) || DEBUG) { + Logging.d(TAG, "name: " + d.name + ", " + + "mode: " + d.connectMode + ", " + + "implementor: " + d.implementor + ", " + + "UUID: " + d.uuid); + } + } + if (isAcousticEchoCancelerSupported()) { // Create an AcousticEchoCanceler and attach it to the AudioRecord on // the specified audio session.