From d5ef6ff258da61fdb2299b7372f746778a82f6ad Mon Sep 17 00:00:00 2001 From: Alessio Bazzica Date: Mon, 7 May 2018 16:33:36 +0200 Subject: [PATCH] Disable WavWriterTest flaky tests on Mac. TBR=titovartem@webrtc.org Bug: webrtc:9247 Change-Id: I3d01ac5dd7d6ac2ff83f2b991238ce003c0182e9 Reviewed-on: https://webrtc-review.googlesource.com/74880 Reviewed-by: Alessio Bazzica Commit-Queue: Alessio Bazzica Cr-Commit-Position: refs/heads/master@{#23152} --- common_audio/wav_file_unittest.cc | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/common_audio/wav_file_unittest.cc b/common_audio/wav_file_unittest.cc index 248273ba0b..39e8968e93 100644 --- a/common_audio/wav_file_unittest.cc +++ b/common_audio/wav_file_unittest.cc @@ -19,12 +19,22 @@ #include "test/gtest.h" #include "test/testsupport/fileutils.h" +// WavWriterTest.CPPFileDescriptor and WavWriterTest.CPP flaky on Mac. +// See webrtc:9247. +#if defined(WEBRTC_MAC) +#define MAYBE_CPP DISABLED_CPP +#define MAYBE_CPPFileDescriptor DISABLED_CPPFileDescriptor +#else +#define MAYBE_CPP CPP +#define MAYBE_CPPFileDescriptor CPPFileDescriptor +#endif + namespace webrtc { static const float kSamples[] = {0.0, 10.0, 4e4, -1e9}; // Write a tiny WAV file with the C++ interface and verify the result. -TEST(WavWriterTest, CPP) { +TEST(WavWriterTest, MAYBE_CPP) { const std::string outfile = test::OutputPath() + "wavtest1.wav"; static const size_t kNumSamples = 3; { @@ -176,7 +186,7 @@ TEST(WavWriterTest, LargeFile) { // Write a tiny WAV file with the the std::FILE interface and verify the // result. -TEST(WavWriterTest, CPPFileDescriptor) { +TEST(WavWriterTest, MAYBE_CPPFileDescriptor) { const std::string outfile = test::OutputPath() + "wavtest1.wav"; static constexpr size_t kNumSamples = 3; {