From d5e3d0f958aa63a93f2e04b57f0d62c2f1a051d5 Mon Sep 17 00:00:00 2001 From: mbonadei Date: Tue, 25 Jul 2017 07:30:06 -0700 Subject: [PATCH] Creating a more generic memcheck suppression Chromium roll into WebRTC is failing because of a memcheck error. The tool suggests to add this suppression: { Memcheck:Uninitialized fun:vfprintf fun:vsnprintf fun:snprintf fun:_ZN7testing9internal220PrintBytesInObjectToEPKhmPSo fun:_ZN7testing8internal14Default... fun:_ZN7testing8internal20MatchPrint... fun:_ZNK7testing8internal29Predicate... } This CL tries to remove some duplication using a more generic pattern. BUG=webrtc:6773 NOTRY=True Review-Url: https://codereview.webrtc.org/2991643002 Cr-Commit-Position: refs/heads/master@{#19132} --- .../valgrind/memcheck/suppressions.txt | 25 +------------------ 1 file changed, 1 insertion(+), 24 deletions(-) diff --git a/tools_webrtc/valgrind/memcheck/suppressions.txt b/tools_webrtc/valgrind/memcheck/suppressions.txt index ef6d09fd83..ba7c314e09 100644 --- a/tools_webrtc/valgrind/memcheck/suppressions.txt +++ b/tools_webrtc/valgrind/memcheck/suppressions.txt @@ -54,35 +54,12 @@ fun:_ZN3rtc47HttpServer_SignalsCloseAfterForcedCloseAll_Test8TestBodyEv } { - bug_6773_3 + bug_6773 Memcheck:Uninitialized fun:vfprintf fun:vsnprintf fun:snprintf ... - fun:_ZN6webrtc36RtcpPacketFirTest_TwoFciEntries_Test8TestBodyEv -} -{ - bug_6773_2 - Memcheck:Uninitialized - fun:vfprintf - fun:vsnprintf - fun:snprintf - fun:_ZN7testing12_GLOBAL__N_126PrintByteSegmentInObjectToEPKhmmPSo - ... - fun:_ZNK6webrtc11MockRtpRtcp11FlexfecSsrcEv - fun:_ZN6webrtc12PacketRouter16TimeToSendPacketEjtlbi - fun:_ZN6webrtc38PacketRouterTest_TimeToSendPacket_Test8TestBodyEv -} -{ - bug_6773_1 - Memcheck:Uninitialized - fun:vfprintf - fun:vsnprintf - fun:snprintf - fun:_ZN7testing12_GLOBAL__N_126PrintByteSegmentInObjectToEPKhmmPSo - ... - fun:_ZN6webrtc28RtcpPacketFirTest_Parse_Test8TestBodyEv } { bug_3446