admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Move video_replay under rtc_tools/.

Browse Source 
As pointed out in [1], RTC public tools should live in rtc_tools.

[1] - https://webrtc-review.googlesource.com/c/src/+/168320/2#message-1f40103105ecb077aeec153c5270575138349a50

Bug: chromium:942546
Change-Id: Ic827d9b31ade9a32bf4ef24d020ef8c81d2c9a5b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168308
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30486}
This commit is contained in:
Mirko Bonadei 2020-02-07 10:02:31 +01:00 committed by Commit Bot
parent 189849fa0f
commit d4c3c3a454
4 changed files with 45 additions and 47 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
BUILD.gn
View File

@ -56,13 +56,13 @@ if (!build_with_chromium) {
"pc:peerconnection_unittests",
"pc:rtc_pc_unittests",
"rtc_tools:rtp_generator",
"rtc_tools:video_replay",
"stats:rtc_stats_unittests",
"system_wrappers:system_wrappers_unittests",
"test",
"video:screenshare_loopback",
"video:sv_loopback",
"video:video_loopback",
"video:video_replay",
]
if (!is_asan) {
# Do not build :webrtc_lib_link_test because lld complains on some OS

44
rtc_tools/BUILD.gn
View File

@ -190,6 +190,50 @@ if (!is_component_build) {
deps += [ "//third_party/webrtc_overrides:webrtc_component" ]
}
}
# This target can be built from Chromium but it doesn't support
# is_component_build=true because it depends on WebRTC testonly code
# which is not part of //third_party/webrtc_overrides:webrtc_component.
rtc_executable("video_replay") {
visibility = [ "*" ]
testonly = true
sources = [ "video_replay.cc" ]
deps = [
"../api/rtc_event_log",
"../api/task_queue:default_task_queue_factory",
"../api/test/video:function_video_factory",
"../api/transport:field_trial_based_config",
"../api/video_codecs:video_codecs_api",
"../call",
"../call:call_interfaces",
"../common_video",
"../media:rtc_internal_video_codecs",
"../rtc_base:checks",
"../rtc_base:rtc_json",
"../rtc_base:stringutils",
"../rtc_base:timeutils",
"../system_wrappers",
"../test:call_config_utils",
"../test:encoder_settings",
"../test:fake_video_codecs",
"../test:null_transport",
"../test:rtp_test_utils",
"../test:run_test",
"../test:run_test_interface",
"../test:test_common",
"../test:test_renderer",
"../test:test_support",
"../test:video_test_common",
"../test:video_test_support",
"//third_party/abseil-cpp/absl/flags:flag",
"//third_party/abseil-cpp/absl/flags:parse",
]
if (build_with_chromium) {
# When building from Chromium, WebRTC's metrics and field trial
# implementations need to be replaced by the Chromium ones.
deps += [ "//third_party/webrtc_overrides:webrtc_component" ]
}
}
}
# Only expose the targets needed by Chromium (e.g. frame_analyzer) to avoid

0
video/video_replay.cc → rtc_tools/video_replay.cc
View File

46
video/BUILD.gn
View File

@ -243,52 +243,6 @@ rtc_library("video_stream_encoder_impl") {
]
}
if (!is_component_build) {
# This target can be built from Chromium but it doesn't support
# is_component_build=true because it depends on WebRTC testonly code
# which is not part of //third_party/webrtc_overrides:webrtc_component.
rtc_executable("video_replay") {
visibility = [ "*" ]
testonly = true
sources = [ "video_replay.cc" ]
deps = [
"../api/rtc_event_log",
"../api/task_queue:default_task_queue_factory",
"../api/test/video:function_video_factory",
"../api/transport:field_trial_based_config",
"../api/video_codecs:video_codecs_api",
"../call",
"../call:call_interfaces",
"../common_video",
"../media:rtc_internal_video_codecs",
"../rtc_base:checks",
"../rtc_base:rtc_json",
"../rtc_base:stringutils",
"../rtc_base:timeutils",
"../system_wrappers",
"../test:call_config_utils",
"../test:encoder_settings",
"../test:fake_video_codecs",
"../test:null_transport",
"../test:rtp_test_utils",
"../test:run_test",
"../test:run_test_interface",
"../test:test_common",
"../test:test_renderer",
"../test:test_support",
"../test:video_test_common",
"../test:video_test_support",
"//third_party/abseil-cpp/absl/flags:flag",
"//third_party/abseil-cpp/absl/flags:parse",
]
if (build_with_chromium) {
# When building from Chromium, WebRTC's metrics and field trial
# implementations need to be replaced by the Chromium ones.
deps += [ "//third_party/webrtc_overrides:webrtc_component" ]
}
}
}
if (rtc_include_tests) {
rtc_library("video_mocks") {
testonly = true