admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reland of Enable -Wunused-lambda-capture warning (patchset #1 id:1 of https://codereview.webrtc.org/3007483002/ )

Browse Source 
Reason for revert:
Relanding not enabling the warning if Xcode clang is used.
See https://cs.chromium.org/chromium/src/build/config/compiler/BUILD.gn?rcl=9de57af4acd3e74cde57e62dd48e58290eeb1481&l=1216
for details.

Original issue's description:
> Revert of Enable -Wunused-lambda-capture warning (patchset #1 id:1 of https://codereview.webrtc.org/2999403002/ )
>
> Reason for revert:
> Breaks iOS framework builder.
>
> Original issue's description:
> > Enable -Wunused-lambda-capture warning
> >
> > This should prevent some build errors downstream.
> > The warning is currrently disabled in Chromium:
> > https://cs.chromium.org/chromium/src/build/config/compiler/BUILD.gn?rcl=735aa36217a394455f70aad87e2c844053fd810a&l=1214
> > (see https://crbug.com/681136 for more info).
> >
> > BUG=webrtc:7133
> > NOTRY=True
> >
> > Review-Url: https://codereview.webrtc.org/2999403002
> > Cr-Commit-Position: refs/heads/master@{#19466}
> > Committed: fd7cffa433
>
> TBR=charujain@webrtc.org,charujain@google.com
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7133
>
> Review-Url: https://codereview.webrtc.org/3007483002
> Cr-Commit-Position: refs/heads/master@{#19473}
> Committed: aa0d2e694a

TBR=charujain@webrtc.org,charujain@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7133

Review-Url: https://codereview.webrtc.org/3002203002
Cr-Commit-Position: refs/heads/master@{#19475}
This commit is contained in:
kjellander 2017-08-23 12:31:31 -07:00 committed by Commit Bot
parent dab31ce1fa
commit d4ab933e2c
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
webrtc/BUILD.gn
View File

@ -179,6 +179,15 @@ config("common_config") {
"-Winconsistent-missing-override",
"-Wundef",
]
# use_xcode_clang only refers to the iOS toolchain, host binaries use
# chromium's clang always.
if (!is_nacl &&
(!use_xcode_clang || current_toolchain == host_toolchain)) {
# Flags NaCl (Clang 3.7) and Xcode 7.3 (Clang clang-703.0.31) do not
# recognize.
cflags += [ "-Wunused-lambda-capture" ]
}
}
}