admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Disable flaky PeerConnectionSimulcastWithMediaFlowTests on ASAN.

Browse Source 
The test is flaking during shutdown in general, but this is especially
apparent on ASAN bots that don't retry. It is related to
heap-use-after-free and is believef to be a test-only problem.

Bug: webrtc:15018
Change-Id: I593c18dbbe45605404b17af74fd7101f118db7bb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/299003
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#39661}
This commit is contained in:
Henrik Boström 2023-03-23 18:24:55 +01:00 committed by WebRTC LUCI CQ
parent adb946054c
commit d3e765e4eb
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
pc/peer_connection_simulcast_unittest.cc
View File

@ -168,7 +168,11 @@ const webrtc::RTCOutboundRtpStreamStats* FindOutboundRtpByRid(
namespace webrtc {
constexpr TimeDelta kDefaultTimeout = TimeDelta::Seconds(5);
// Only used by tests disabled under ASAN, avoids unsued variable compile error.
#if !defined(ADDRESS_SANITIZER)
constexpr TimeDelta kLongTimeoutForRampingUp = TimeDelta::Seconds(30);
#endif // !defined(ADDRESS_SANITIZER)
class PeerConnectionSimulcastTests : public ::testing::Test {
public:
@ -1137,6 +1141,12 @@ TEST_F(PeerConnectionSimulcastWithMediaFlowTests,
EXPECT_THAT(*outbound_rtps[0]->scalability_mode, StrEq("L1T1"));
}
// TODO(https://crbug.com/webrtc/15018): Investigate heap-use-after free during
// shutdown of the test that is flakily happening on bots. It's not only
// happening on ASAN, but it is rare enough on non-ASAN that we don't have to
// disable everywhere.
#if !defined(ADDRESS_SANITIZER)
TEST_F(PeerConnectionSimulcastWithMediaFlowTests,
SendingThreeEncodings_VP8_Simulcast) {
rtc::scoped_refptr<PeerConnectionTestWrapper> local_pc_wrapper = CreatePc();
@ -1622,4 +1632,6 @@ TEST_F(PeerConnectionSimulcastWithMediaFlowTests,
EXPECT_THAT(*outbound_rtps[2]->scalability_mode, StrEq("L1T3"));
}
#endif // !defined(ADDRESS_SANITIZER)
} // namespace webrtc