From d2cb1f872efdbf29bbd661133e0cd3eb4b854b9b Mon Sep 17 00:00:00 2001 From: Artem Titov Date: Wed, 28 Sep 2022 14:28:13 +0200 Subject: [PATCH] [PCLF] Fix rounding issue in NetworkQualityMetricsReporter Bug: b/246095034 Change-Id: Idba4aef450ade431822c9d5e43870281ded55f73 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277220 Commit-Queue: Artem Titov Reviewed-by: Mirko Bonadei Cr-Commit-Position: refs/heads/main@{#38235} --- test/pc/e2e/network_quality_metrics_reporter.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/test/pc/e2e/network_quality_metrics_reporter.cc b/test/pc/e2e/network_quality_metrics_reporter.cc index c5d47beb37..fbcc5b30fa 100644 --- a/test/pc/e2e/network_quality_metrics_reporter.cc +++ b/test/pc/e2e/network_quality_metrics_reporter.cc @@ -132,7 +132,7 @@ void NetworkQualityMetricsReporter::ReportStats( Unit::kUnitless, ImprovementDirection::kNeitherIsBetter); metrics_logger_->LogSingleValueMetric( "average_send_rate", GetTestCaseName(network_label), - stats->PacketsSent() >= 2 ? stats->AverageSendRate().kbps() : 0, + stats->PacketsSent() >= 2 ? stats->AverageSendRate().kbps() : 0, Unit::kKilobitsPerSecond, ImprovementDirection::kNeitherIsBetter); metrics_logger_->LogSingleValueMetric( "bytes_discarded_no_receiver", GetTestCaseName(network_label), @@ -152,7 +152,8 @@ void NetworkQualityMetricsReporter::ReportStats( ImprovementDirection::kNeitherIsBetter); metrics_logger_->LogSingleValueMetric( "average_receive_rate", GetTestCaseName(network_label), - stats->PacketsReceived() >= 2 ? stats->AverageReceiveRate().kbps() : 0, + stats->PacketsReceived() >= 2 ? stats->AverageReceiveRate().kbps() + : 0, Unit::kKilobitsPerSecond, ImprovementDirection::kNeitherIsBetter); metrics_logger_->LogSingleValueMetric( "sent_packets_loss", GetTestCaseName(network_label), packet_loss,