admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Uncomment commented-out sequence-checks in call.cc

Browse Source 
Two of the three commented-out checks should have been fixed by https://codereview.webrtc.org/2998923002/. The last will be fixed in a separate CL.

BUG=webrtc:8116

Review-Url: https://codereview.webrtc.org/2999253002
Cr-Commit-Position: refs/heads/master@{#19511}
This commit is contained in:
eladalon 2017-08-25 02:55:57 -07:00 committed by Commit Bot
parent 27e812e369
commit d1dd2f79e5
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
webrtc/call/call.cc
View File

@ -590,9 +590,7 @@ void Call::UpdateReceiveHistograms() {
}
PacketReceiver* Call::Receiver() {
// TODO(solenberg): Some test cases in EndToEndTest use this from a different
// thread. Re-enable once that is fixed.
// RTC_DCHECK_CALLED_SEQUENTIALLY(&configuration_sequence_checker_);
RTC_DCHECK_CALLED_SEQUENTIALLY(&configuration_sequence_checker_);
return this;
}
@ -1372,10 +1370,7 @@ PacketReceiver::DeliveryStatus Call::DeliverPacket(
const uint8_t* packet,
size_t length,
const PacketTime& packet_time) {
// TODO(solenberg): Tests call this function on a network thread, libjingle
// calls on the worker thread. We should move towards always using a network
// thread. Then this check can be enabled.
// RTC_DCHECK_CALLED_SEQUENTIALLY(&configuration_sequence_checker_);
RTC_DCHECK_CALLED_SEQUENTIALLY(&configuration_sequence_checker_);
if (RtpHeaderParser::IsRtcp(packet, length))
return DeliverRtcp(media_type, packet, length);