From d036c6582e130eb558ac12b56ea2d86909100f6e Mon Sep 17 00:00:00 2001 From: Konrad Hofbauer Date: Thu, 14 Feb 2019 16:17:28 +0100 Subject: [PATCH] Clarify and unify outgoing and incoming packet loss rate plots. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: none Change-Id: Idefb12f389547c63d8ce1faa10e3796687108222 Reviewed-on: https://webrtc-review.googlesource.com/c/123100 Reviewed-by: Björn Terelius Commit-Queue: Konrad Hofbauer Cr-Commit-Position: refs/heads/master@{#26691} --- rtc_tools/event_log_visualizer/analyzer.cc | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/rtc_tools/event_log_visualizer/analyzer.cc b/rtc_tools/event_log_visualizer/analyzer.cc index 5c3e0061af..a77f378083 100644 --- a/rtc_tools/event_log_visualizer/analyzer.cc +++ b/rtc_tools/event_log_visualizer/analyzer.cc @@ -717,9 +717,8 @@ void EventLogAnalyzer::CreateIncomingPacketLossGraph(Plot* plot) { plot->SetXAxis(config_.CallBeginTimeSec(), config_.CallEndTimeSec(), "Time (s)", kLeftMargin, kRightMargin); - plot->SetSuggestedYAxis(0, 1, "Estimated loss rate (%)", kBottomMargin, - kTopMargin); - plot->SetTitle("Estimated incoming loss rate"); + plot->SetSuggestedYAxis(0, 1, "Loss rate (in %)", kBottomMargin, kTopMargin); + plot->SetTitle("Incoming packet loss (derived from incoming packets)"); } void EventLogAnalyzer::CreateIncomingDelayGraph(Plot* plot) { @@ -795,9 +794,8 @@ void EventLogAnalyzer::CreateFractionLossGraph(Plot* plot) { plot->AppendTimeSeries(std::move(time_series)); plot->SetXAxis(config_.CallBeginTimeSec(), config_.CallEndTimeSec(), "Time (s)", kLeftMargin, kRightMargin); - plot->SetSuggestedYAxis(0, 10, "Percent lost packets", kBottomMargin, - kTopMargin); - plot->SetTitle("Reported packet loss"); + plot->SetSuggestedYAxis(0, 10, "Loss rate (in %)", kBottomMargin, kTopMargin); + plot->SetTitle("Outgoing packet loss (as reported by BWE)"); } // Plot the total bandwidth used by all RTP streams.