From d004aee4a41f3fba3b29ef33be2c4f07f2ceb1e7 Mon Sep 17 00:00:00 2001 From: Danil Chapovalov Date: Mon, 9 Dec 2024 18:09:53 +0100 Subject: [PATCH] Allow absl map and set containers in WebRTC Bug: None No-Try: True Change-Id: I84218daf71de115af74e0484bc26e798f125297a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/370762 Reviewed-by: Harald Alvestrand Commit-Queue: Danil Chapovalov Cr-Commit-Position: refs/heads/main@{#43529} --- DEPS | 3 ++- g3doc/abseil-in-webrtc.md | 4 +++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/DEPS b/DEPS index e479b408bb..81e2b8b423 100644 --- a/DEPS +++ b/DEPS @@ -2219,7 +2219,8 @@ include_rules = [ "+absl/base/nullability.h", "+absl/base/macros.h", "+absl/cleanup/cleanup.h", - "+absl/container/inlined_vector.h", + "+absl/container", + "-absl/container/fixed_array.h" "+absl/functional/any_invocable.h", "+absl/functional/bind_front.h", "+absl/memory/memory.h", diff --git a/g3doc/abseil-in-webrtc.md b/g3doc/abseil-in-webrtc.md index 66edbb8ac0..beaa5cc45b 100644 --- a/g3doc/abseil-in-webrtc.md +++ b/g3doc/abseil-in-webrtc.md @@ -27,6 +27,7 @@ on a monolithic Abseil build target that will generate a shared library. * `absl::AnyInvocable` * `absl::bind_front` * `absl::Cleanup` +* [Hash tables, and B-tree ordered][abseil-containers] containers * `absl::InlinedVector` * `absl::Nonnull` and `absl::Nullable` * `absl::WrapUnique` @@ -48,6 +49,7 @@ on a monolithic Abseil build target that will generate a shared library. * ABSL_FLAG is allowed in tests and tools, but disallowed in in non-test code. +[abseil-containers]: https://abseil.io/docs/cpp/guides/container ## **Disallowed** @@ -81,5 +83,5 @@ with a modest number of arguments can easily add several hundred bytes to the binary. Exception: Single-argument absl::StrCat is allowed in order to make it -easy to use AbslStringify. See [TOTW #2015](https://abseil.io/tips/215) for +easy to use AbslStringify. See [TOTW #215](https://abseil.io/tips/215) for details on AbslStringify.