From cf39dd5d82a565f1ec5fd45453208adf4ee01407 Mon Sep 17 00:00:00 2001 From: tommi Date: Fri, 7 Jul 2017 16:24:34 -0700 Subject: [PATCH] Add RTC_FROM_HERE location information to two DCHECKs in ProcessThread. BUG=none TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2967693002 Cr-Commit-Position: refs/heads/master@{#18937} --- webrtc/modules/utility/source/process_thread_impl.cc | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/webrtc/modules/utility/source/process_thread_impl.cc b/webrtc/modules/utility/source/process_thread_impl.cc index 2f8be6c210..b3057ec088 100644 --- a/webrtc/modules/utility/source/process_thread_impl.cc +++ b/webrtc/modules/utility/source/process_thread_impl.cc @@ -118,14 +118,17 @@ void ProcessThreadImpl::PostTask(std::unique_ptr task) { void ProcessThreadImpl::RegisterModule(Module* module, const rtc::Location& from) { RTC_DCHECK(thread_checker_.CalledOnValidThread()); - RTC_DCHECK(module); + RTC_DCHECK(module) << from.ToString(); #if RTC_DCHECK_IS_ON { // Catch programmer error. rtc::CritScope lock(&lock_); - for (const ModuleCallback& mc : modules_) - RTC_DCHECK(mc.module != module); + for (const ModuleCallback& mc : modules_) { + RTC_DCHECK(mc.module != module) + << "Already registered here: " << mc.location.ToString() << "\n" + << "Now attempting from here: " << from.ToString(); + } } #endif