From ce83ae1c19eb3fb8aea84d8e02c2c005115e0440 Mon Sep 17 00:00:00 2001 From: Henrik Kjellander Date: Tue, 10 Nov 2015 11:08:27 +0100 Subject: [PATCH] Improve informative message in codereview.settings. In https://codereview.webrtc.org/1389963002 the message displayed when trying to create a CL from an unsupported location was improved. However it's confusing for developers working from a WebRTC checkout if they stand in src/webrtc when trying to create a CL. R=henrika@webrtc.org, phoglund@webrtc.org Review URL: https://codereview.webrtc.org/1432073002 . Cr-Commit-Position: refs/heads/master@{#10571} --- talk/codereview.settings | 7 ++++--- webrtc/codereview.settings | 7 ++++--- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/talk/codereview.settings b/talk/codereview.settings index 97bee14549..c441cc61bc 100644 --- a/talk/codereview.settings +++ b/talk/codereview.settings @@ -1,4 +1,5 @@ -Creating CLs from this location is not supported! -Please create a full WebRTC checkout using 'fetch webrtc' -or by cloning https://chromium.googlesource.com/external/webrtc +Creating CLs from this location is not supported! Please make sure the current +working directory is the parent directory of this directory. +If you're working with a Chromium checkout, you'll have to create a full WebRTC +checkout and upload a CL from that. See http://www.webrtc.org for instructions. diff --git a/webrtc/codereview.settings b/webrtc/codereview.settings index 97bee14549..c441cc61bc 100644 --- a/webrtc/codereview.settings +++ b/webrtc/codereview.settings @@ -1,4 +1,5 @@ -Creating CLs from this location is not supported! -Please create a full WebRTC checkout using 'fetch webrtc' -or by cloning https://chromium.googlesource.com/external/webrtc +Creating CLs from this location is not supported! Please make sure the current +working directory is the parent directory of this directory. +If you're working with a Chromium checkout, you'll have to create a full WebRTC +checkout and upload a CL from that. See http://www.webrtc.org for instructions.