From ce754f692e146ed28a3f7d48b23641c1d4e22adb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Erik=20Spr=C3=A5ng?= Date: Tue, 19 Oct 2021 15:58:47 +0000 Subject: [PATCH] Revert "Reland "Turn on WebRTC-TaskQueuePacer by defualt."" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit 3a1051204fbe8aa6700f5a770435e48eef7218e5. Reason for revert: Seems to cause another VideoSendStreamTest (SwitchesToScreenshareAndBack) to intermittently deadlock on Mac. Original change's description: > Reland "Turn on WebRTC-TaskQueuePacer by defualt." > > This is a reland of b251145e38fdd08fe7320b0ddb3ca0f698473fa5 > Flaky test has been disabled, see webrtc:13294 > > Original change's description: > > Turn on WebRTC-TaskQueuePacer by defualt. > > > > Bug: webrtc:10809 > > Change-Id: If58ae3d9debc69ee68e6aeb6cecf010e60f6426f > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/233580 > > Reviewed-by: Christoffer Rodbro > > Commit-Queue: Erik Språng > > Cr-Commit-Position: refs/heads/main@{#35145} > > Bug: webrtc:10809 > Change-Id: Id76e9396f2f639caee51cf1cd895ae6deac4e259 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/235662 > Reviewed-by: Evan Shrubsole > Commit-Queue: Evan Shrubsole > Cr-Commit-Position: refs/heads/main@{#35237} TBR=webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com,eshr@webrtc.org,sprang@webrtc.org Change-Id: Idad7023b0595c6cfefa7c866091d3ed014a49839 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:10809 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/235720 Reviewed-by: Erik Språng Commit-Queue: Erik Språng Cr-Commit-Position: refs/heads/main@{#35242} --- call/rtp_transport_controller_send.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/call/rtp_transport_controller_send.cc b/call/rtp_transport_controller_send.cc index 9d27b330cb..f7b6b11fd7 100644 --- a/call/rtp_transport_controller_send.cc +++ b/call/rtp_transport_controller_send.cc @@ -89,7 +89,7 @@ RtpTransportControllerSend::RtpTransportControllerSend( bitrate_configurator_(bitrate_config), pacer_started_(false), process_thread_(std::move(process_thread)), - use_task_queue_pacer_(!IsDisabled(trials, "WebRTC-TaskQueuePacer")), + use_task_queue_pacer_(IsEnabled(trials, "WebRTC-TaskQueuePacer")), process_thread_pacer_(use_task_queue_pacer_ ? nullptr : new PacedSender(clock,