From cd8ae61b279809a3e0e9da926f9bb204f49c1c8a Mon Sep 17 00:00:00 2001 From: ehmaldonado Date: Wed, 24 Aug 2016 02:44:14 -0700 Subject: [PATCH] Add missing dependencies to setup_links. Fixes the following error for Android GN bots when trying to roll Chromium into WebRTC. Full logs at: https://build.chromium.org/p/tryserver.webrtc/builders/android_gn_dbg/builds/13405/steps/generate_build_files/logs/stdio /b/c/b/android_gn_dbg/src/buildtools/linux64/gn gen //out/Debug --check -> returned 1 ERROR at //build/config/android/internal_rules.gni:140:23: Can't load input file. deps += [ "${_target_label}__build_config" ] ^------------------------------- Unable to load: /b/c/b/android_gn_dbg/src/third_party/byte_buddy/BUILD.gn I also checked in the secondary tree for: /b/c/b/android_gn_dbg/src/build/secondary/third_party/byte_buddy/BUILD.gn GN gen failed: 1 BUG=522043 NOTRY=True Review-Url: https://codereview.webrtc.org/2268343002 Cr-Commit-Position: refs/heads/master@{#13886} --- .gitignore | 2 ++ setup_links.py | 2 ++ 2 files changed, 4 insertions(+) diff --git a/.gitignore b/.gitignore index 72cfb55ec2..f68f2be40c 100644 --- a/.gitignore +++ b/.gitignore @@ -83,6 +83,7 @@ /third_party/binutils /third_party/boringssl /third_party/bouncycastle +/third_party/byte_buddy /third_party/catapult /third_party/ced /third_party/clang_format @@ -126,6 +127,7 @@ /third_party/modp_b64 /third_party/nss /third_party/oauth2 +/third_party/objenesis /third_party/ocmock /third_party/openh264 /third_party/openmax_dl diff --git a/setup_links.py b/setup_links.py index 612778aea6..5705eaa4a8 100755 --- a/setup_links.py +++ b/setup_links.py @@ -93,6 +93,7 @@ if 'android' in target_os: 'third_party/appurify-python', 'third_party/ashmem', 'third_party/bouncycastle', + 'third_party/byte_buddy', 'third_party/catapult', 'third_party/ced', 'third_party/closure_compiler', @@ -107,6 +108,7 @@ if 'android' in target_os: 'third_party/libxml', 'third_party/mockito', 'third_party/modp_b64', + 'third_party/objenesis', 'third_party/ow2_asm', 'third_party/requests', 'third_party/robolectric',