From cc8b14b1ec418979393f101df648a876cc8ecaf8 Mon Sep 17 00:00:00 2001 From: jansson Date: Tue, 23 May 2017 08:31:11 -0700 Subject: [PATCH] =?UTF-8?q?Revert=20of=20Remove=20unecessary=20non=20fatal?= =?UTF-8?q?=20error=20statement=20that=20very=20often=20is=20printed=20in?= =?UTF-8?q?=20the=20PSNR=20or=20SSIM=20metric=20n=E2=80=A6=20(patchset=20#?= =?UTF-8?q?1=20id:1=20of=20https://codereview.webrtc.org/2901793002/=20)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Reason for revert: Looks like we need the return there after all: derefence error in: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fclient.webrtc.perf%2FAndroid64_Tests__L_Nexus9_%2F2967%2F%2B%2Frecipes%2Fsteps%2Fvideo_quality_loopback_test%2F0%2Fstdout Original issue's description: > Remove unecessary non fatal error statement that very often is printed in the PSNR or SSIM metric numbered list > > BUG=webrtc:7698 > NOTRY=TRUE > > Review-Url: https://codereview.webrtc.org/2901793002 > Cr-Commit-Position: refs/heads/master@{#18234} > Committed: https://chromium.googlesource.com/external/webrtc/+/18d023f9ee6201be20e4bc68e3fc070404a8edbc TBR=kjellander@webrtc.org,oprypin@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7698 Review-Url: https://codereview.webrtc.org/2899973004 Cr-Commit-Position: refs/heads/master@{#18239} --- webrtc/tools/frame_analyzer/video_quality_analysis.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/webrtc/tools/frame_analyzer/video_quality_analysis.cc b/webrtc/tools/frame_analyzer/video_quality_analysis.cc index d71ac573b7..66ca469ecd 100644 --- a/webrtc/tools/frame_analyzer/video_quality_analysis.cc +++ b/webrtc/tools/frame_analyzer/video_quality_analysis.cc @@ -460,6 +460,10 @@ void PrintMaxRepeatedAndSkippedFrames(FILE* output, } continue; } + fprintf(stderr, + "Found barcode %d in test video, which is not in reference video", + it_test->first); + return; } fprintf(output, "RESULT Max_repeated: %s= %d\n", label.c_str(),