admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix H.265 bitstream parser incorrect PPS reference.

Browse Source 
H.265 bitstream parser currently always assume pps id to be 0 when
calculating the last slice QP. This assumption is incorrect.

Bug: webrtc:13485
Change-Id: I06918df035e8e4a8e68eb3002a49b824ffd5f516
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/337080
Commit-Queue: Jianlin Qiu <jianlin.qiu@intel.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41636}
This commit is contained in:
Qiu Jianlin 2024-01-31 11:13:07 +08:00 committed by WebRTC LUCI CQ
parent 056782c4b5
commit cc83e32cdb
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
common_video/h265/h265_bitstream_parser.cc
View File

@ -531,8 +531,7 @@ absl::optional<int> H265BitstreamParser::GetLastSliceQp() const {
if (!last_slice_qp_delta_ || !last_slice_pps_id_) { if (!last_slice_qp_delta_ || !last_slice_pps_id_) {
return absl::nullopt; return absl::nullopt;
} }
uint32_t pps_id = 0; const H265PpsParser::PpsState* pps = GetPPS(last_slice_pps_id_.value());
const H265PpsParser::PpsState* pps = GetPPS(pps_id);
if (!pps) if (!pps)
return absl::nullopt; return absl::nullopt;
const int parsed_qp = 26 + pps->init_qp_minus26 + *last_slice_qp_delta_; const int parsed_qp = 26 + pps->init_qp_minus26 + *last_slice_qp_delta_;