admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Fork //base/test/google_test_runner"

Browse Source 
This reverts commit 166650ada7ce6aa503bfab77dcbd7f0835b238b2.

Reason for revert: Seems to break downstream on-device ios tests.

Original change's description:
> Fork //base/test/google_test_runner
>
> (Used to run gtests on iOS, but we don't want to depend on //base.)
>
> Optimistically try to use the existing partial fork
>
> Bug: webrtc:13402
> Change-Id: I10528670862f2db67e77adb73b8a71b19642666d
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260328
> Commit-Queue: Björn Terelius <terelius@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#36703}

Bug: webrtc:13402
Change-Id: I5bef679e95693b7a6942375801daf9273d260e1d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260462
Auto-Submit: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Owners-Override: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36705}
This commit is contained in:
Björn Terelius 2022-04-29 11:23:05 +00:00 committed by WebRTC LUCI CQ
parent 6228d870dc
commit cbf07f70e2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
webrtc.gni
View File

@ -498,10 +498,10 @@ template("rtc_test") {
]
}
# Build //test:test_support when the test is not a real XCTest.
# Build //base/test:google_test_runner when the test is not a real XCTest.
if (is_ios && rtc_include_tests) {
if (!defined(invoker.is_xctest) || !invoker.is_xctest) {
xctest_module_target = "//test:test_support"
xctest_module_target = "//base/test:google_test_runner"
}
}