From cb95f54ee469cd9682ffecd404d37c5e4d58edb0 Mon Sep 17 00:00:00 2001 From: Tommi Date: Sat, 12 Dec 2015 16:54:32 +0100 Subject: [PATCH] Remove pointless move() to fix build on clang/win. Fixes: ..\..\third_party\libjingle\source\talk\app\webrtc\remoteaudiosource.cc(100,15) : error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move] ssrc, std::move(rtc::scoped_ptr(new Sink(this)))); ^ ..\..\third_party\libjingle\source\talk\app\webrtc\remoteaudiosource.cc(100,15) : note: remove std::move call here ssrc, std::move(rtc::scoped_ptr(new Sink(this)))); ^~~~~~~~~~ R=thakis@chromium.org TBR=thakis@chromium.org Review URL: https://codereview.webrtc.org/1517253004 . Cr-Commit-Position: refs/heads/master@{#10999} --- talk/app/webrtc/remoteaudiosource.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/talk/app/webrtc/remoteaudiosource.cc b/talk/app/webrtc/remoteaudiosource.cc index e5af1e9487..a35f0bb787 100644 --- a/talk/app/webrtc/remoteaudiosource.cc +++ b/talk/app/webrtc/remoteaudiosource.cc @@ -97,7 +97,7 @@ void RemoteAudioSource::Initialize(uint32_t ssrc, // we register for callbacks here and not on demand in AddSink. if (provider) { // May be null in tests. provider->SetRawAudioSink( - ssrc, std::move(rtc::scoped_ptr(new Sink(this)))); + ssrc, rtc::scoped_ptr(new Sink(this))); } }