admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Provide default implementation of IceTransportInternal::config()

Browse Source 
to be deleted when downstream consumers are upgraded

BUG=webrtc:367395350

Change-Id: I35f1fefdc6535ad443b86176ea600455c2361834
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/370284
Commit-Queue: Philipp Hancke <phancke@meta.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43502}
This commit is contained in:
Philipp Hancke 2024-12-05 13:36:53 -08:00 committed by WebRTC LUCI CQ
parent 89b0f2ef71
commit cab60a0842
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
p2p/base/ice_transport_internal.h
View File

@ -282,7 +282,10 @@ class RTC_EXPORT IceTransportInternal : public rtc::PacketTransportInternal {
virtual void SetRemoteIceMode(IceMode mode) = 0; virtual void SetRemoteIceMode(IceMode mode) = 0;
virtual void SetIceConfig(const IceConfig& config) = 0; virtual void SetIceConfig(const IceConfig& config) = 0;
virtual const IceConfig& config() const = 0; // Default implementation in order to allow downstream usage deletion.
// TODO: bugs.webrtc.org/367395350 - Make virutal when all downstream
// overrides are gone.
virtual const IceConfig& config() const { RTC_CHECK_NOTREACHED(); }
// Start gathering candidates if not already started, or if an ICE restart // Start gathering candidates if not already started, or if an ICE restart
// occurred. // occurred.